Issue 15750043: Fixed up the onboarding and added new tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15750043: Fixed up the onboarding and added new tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by rharding

Modified:
12 years, 5 months ago

Reviewers:
mp+192070

Visibility:
Public.

Description

Fixed up the onboarding and added new tests Local storage has been added to save the user's dismissal of the onboarding. Also new tests before the render function call. Added test to test the new functionality. https://code.launchpad.net/~rharding/juju-gui/qa-ant-onboarding2/+merge/192070 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixed up the onboarding and added new tests #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+146 lines, -326 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	7 chunks	+1 line, -33 lines	0 comments	Download
M	app/modules-debug.js	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	app/subapps/browser/browser.js	View	6 chunks	+35 lines, -1 line	0 comments	Download
D	app/templates/landscape-controls.partial	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	app/templates/overview.handlebars	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	app/views/environment.js	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	app/views/onboarding.js	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	app/views/topology/bundle.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	app/views/topology/landscape.js	View	1 chunk	+0 lines, -73 lines	0 comments	Download
M	app/views/topology/service.js	View	2 chunks	+0 lines, -50 lines	0 comments	Download
M	app/views/topology/topology.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	app/views/utils.js	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	lib/views/browser/main.less	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	lib/views/browser/vars.less	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/views/stylesheet.less	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/test_browser_app.js	View	4 chunks	+64 lines, -1 line	0 comments	Download
M	test/test_environment_view.js	View	1 chunk	+0 lines, -39 lines	0 comments	Download
M	test/test_landscape.js	View	1 chunk	+0 lines, -62 lines	0 comments	Download
M	test/test_onboarding.js	View	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rharding

12 years, 5 months ago (2013-10-22 00:42:36 UTC) #3

*** Submitted:

Fixed up the onboarding and added new tests

Local storage has been added to save the user's dismissal of the onboarding.
Also new tests before the render function call. Added test to test the new
functionality.

R=
CC=
https://codereview.appspot.com/15750043

Expand All Messages | Collapse All Messages