Issue 157220043: code review 157220043: debug/pe: use appropriate type for sizeofOptionalHeader32

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 157220043: code review 157220043: debug/pe: use appropriate type for sizeofOptionalHeader32 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by brainman

Modified:
10 years, 4 months ago

Reviewers:
gobot, rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

debug/pe: use appropriate type for sizeofOptionalHeader32

Patch Set 1 #

Patch Set 2 : diff -r 3484e15daca1b6931382a7317b15a639d46b9465 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3484e15daca1b6931382a7317b15a639d46b9465 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a2d6756cd36136e346d65b13ec5167be186bda14 https://go.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/debug/pe/file.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 4 months ago (2014-10-20 22:15:04 UTC) #1

brainman

*** Submitted as https://code.google.com/p/go/source/detail?r=73c349c7a77f *** debug/pe: use appropriate type for sizeofOptionalHeader32 LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews ...

10 years, 4 months ago (2014-10-20 23:02:42 UTC) #3

gobot

10 years, 4 months ago (2014-10-20 23:04:34 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/199fe84cf6fad5361811fb15bd6c47b8ff05c5ba

Expand All Messages | Collapse All Messages