Issue 15720044: code review 15720044: publicsuffix: update tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15720044: code review 15720044: publicsuffix: update tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by volker.dobler

Modified:
11 years, 5 months ago

Reviewers:
nigeltao

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

publicsuffix: update tests Update the test cases to reflect the updated test_psl.txt found on http://publicsuffix.org.

Patch Set 1 #

Patch Set 2 : diff -r 355ff0aa1b2e https://code.google.com/p/go.net/ #

Patch Set 3 : diff -r 355ff0aa1b2e https://code.google.com/p/go.net/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	publicsuffix/list_test.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

volker.dobler

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net/

11 years, 5 months ago (2013-10-22 10:05:07 UTC) #1

nigeltao

11 years, 5 months ago (2013-10-22 21:19:56 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=16444c3fecfd&repo=net ***

publicsuffix: update tests

Update the test cases to reflect the updated
test_psl.txt found on http://publicsuffix.org.

R=nigeltao
CC=golang-dev
https://codereview.appspot.com/15720044

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages