code review 157150043: reflect: fix TestAllocations now that interfaces hold o...

reflect: fix TestAllocations now that interfaces hold only pointers

This test was failing but did not break the build because it
was not run when -test.short was used.

[iant, 2014-10-19 04:37:01]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-10-19 13:39:46]

LGTM


On Sun, Oct 19, 2014 at 6:37 AM, <iant@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> reflect: fix TestAllocations now that interfaces hold only pointers
>
> This test was failing but did not break the build because it
> was not run when -test.short was used.
>
> Please review this at https://codereview.appspot.com/157150043/
>
> Affected files (+14, -3 lines):
>   M src/reflect/all_test.go
>
>
> Index: src/reflect/all_test.go
> ===================================================================
> --- a/src/reflect/all_test.go
> +++ b/src/reflect/all_test.go
> @@ -2502,10 +2502,21 @@
>         noAlloc(t, 100, func(j int) {
>                 var i interface{}
>                 var v Value
> -               i = 42 + j
> +
> +               // We can uncomment this when compiler escape analysis
> +               // is good enough to see that the integer assigned to i
> +               // does not escape and therefore need not be allocated.
> +               //
> +               // i = 42 + j
> +               // v = ValueOf(i)
> +               // if int(v.Int()) != 42+j {
> +               //      panic("wrong int")
> +               // }
> +
> +               i = func(j int) int { return j }
>                 v = ValueOf(i)
> -               if int(v.Int()) != 42+j {
> -                       panic("wrong int")
> +               if v.Interface().(func(int) int)(j) != j {
> +                       panic("wrong result")
>                 }
>         })
>  }
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[iant, 2014-10-20 18:10:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=6d6fbf7dee5b ***

reflect: fix TestAllocations now that interfaces hold only pointers

This test was failing but did not break the build because it
was not run when -test.short was used.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/157150043