crypto/tls: add initial client implementation.

crypto/tls: add initial client implementation.

[agl1, 2009-11-19 00:54:57]

This client code will connection and validate certs etc. There's still much work
to be done and I want to write a test that plays the server against the client.
However, the current state works and I don't want to make this CL any larger
than it already is.

[rsc, 2009-11-19 06:23:12]

LGTM

http://codereview.appspot.com/157076/diff/1/3
File src/pkg/crypto/tls/common.go (right):

http://codereview.appspot.com/157076/diff/1/3#newcode70
src/pkg/crypto/tls/common.go:70: RootCAs		*RootCASet;
Root *CASet;
?

http://codereview.appspot.com/157076/diff/1/4
File src/pkg/crypto/tls/handshake_client.go (right):

http://codereview.appspot.com/157076/diff/1/4#newcode36
src/pkg/crypto/tls/handshake_client.go:36: hello := new(clientHelloMsg);
write this as a composite literal for readability:

hello := &clientHelloMsg{
    major: defaultMajor,
    minor: defaultMinor,
    ...
    random: make([]byte, 32),
}
hello.random[0] = ...

http://codereview.appspot.com/157076/diff/1/9
File src/pkg/crypto/tls/root_ca_set.go (right):

http://codereview.appspot.com/157076/diff/1/9#newcode12
src/pkg/crypto/tls/root_ca_set.go:12: // A RootCASet is a set of certificates.
Isn't this just a CASet?

[agl, 2009-11-21 23:41:16]

http://codereview.appspot.com/157076/diff/1/3
File src/pkg/crypto/tls/common.go (right):

http://codereview.appspot.com/157076/diff/1/3#newcode70
src/pkg/crypto/tls/common.go:70: RootCAs		*RootCASet;
On 2009/11/19 06:23:12, rsc wrote:
> Root *CASet;
> ?
> 

Changed RootCASet to just CASet. (Also renamed the .go file of the same name.)

http://codereview.appspot.com/157076/diff/1/4
File src/pkg/crypto/tls/handshake_client.go (right):

http://codereview.appspot.com/157076/diff/1/4#newcode36
src/pkg/crypto/tls/handshake_client.go:36: hello := new(clientHelloMsg);
On 2009/11/19 06:23:12, rsc wrote:
> write this as a composite literal for readability:
> 
> hello := &clientHelloMsg{
>     major: defaultMajor,
>     minor: defaultMinor,
>     ...
>     random: make([]byte, 32),
> }
> hello.random[0] = ...
> 

Done.

[agl1, 2009-11-21 23:53:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=2f32e74ab96e ***

crypto/tls: add initial client implementation.

R=rsc, agl
CC=golang-dev
http://codereview.appspot.com/157076