crypto/tls: add initial client implementation.

src/pkg/crypto/tls/handshake_client.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package tls
 
 import (
         "crypto/hmac";
         "crypto/rc4";
         "crypto/rsa";
@@ skipping 15 matching lines @@
         h.writeChan = writeChan;
         h.controlChan = controlChan;
         h.msgChan = msgChan;
         h.config = config;
 
         defer close(writeChan);
         defer close(controlChan);
 
         finishedHash := newFinishedHash();
 
-        hello := new(clientHelloMsg);

[rsc, 2009/11/19 06:23:12]

write this as a composite literal for readability:

hello := &clientHelloMsg{
    major: defaultMajor,
    minor: defaultMinor,
    ...
    random: make([]byte, 32),
}
hello.random[0] = ...

[agl, 2009/11/21 23:41:16]

Done.

-        hello.major = defaultMajor;
-        hello.minor = defaultMinor;
-        hello.cipherSuites = []uint16{TLS_RSA_WITH_RC4_128_SHA};
-        hello.compressionMethods = []uint8{compressionNone};
+        hello := &clientHelloMsg{
+                major: defaultMajor,
+                minor: defaultMinor,
+                cipherSuites: []uint16{TLS_RSA_WITH_RC4_128_SHA},
+                compressionMethods: []uint8{compressionNone},
+                random: make([]byte, 32),
+        };
+
         currentTime := uint32(config.Time());
-        hello.random = make([]byte, 32);
         hello.random[0] = byte(currentTime >> 24);
         hello.random[1] = byte(currentTime >> 16);
         hello.random[2] = byte(currentTime >> 8);
         hello.random[3] = byte(currentTime);
         _, err := io.ReadFull(config.Rand, hello.random[4:len(hello.random)]);
         if err != nil {
                 h.error(alertInternalError);
                 return;
         }
 
@@ skipping 161 matching lines @@
                 // to tell it about the error.
                 go func() {
                         for _ = range h.msgChan {
                         }
                 }();
                 h.controlChan <- ConnectionState{false, "", e};
                 close(h.controlChan);
                 h.writeChan <- alert{alertLevelError, e};
         }
 }