Bug fix for lp:1243942

Bug fix for lp:1243942

Move test package into testing directory to prevent gocheck being included in build

https://code.launchpad.net/~mattyw/juju-core/gocheck_included_in_build_fix/+merge/192411

(do not edit description out of merge proposal)

[mattyw, 2013-10-23 22:05:20]

Please take a look.

[axw, 2013-10-23 22:42:20]

On 2013/10/23 22:05:20, matthew.williams wrote:
> Please take a look.

The lp: points to "Open Rails Tracker". I don't think that's right? :)

Just as a general thing, it's useful to include a description of the fix, as
well as a pointer to the bug.

[mattyw, 2013-10-23 22:58:47]

On 2013/10/23 22:42:20, axw wrote:
> On 2013/10/23 22:05:20, matthew.williams wrote:
> > Please take a look.
> 
> The lp: points to "Open Rails Tracker". I don't think that's right? :)
> 
> Just as a general thing, it's useful to include a description of the fix, as
> well as a pointer to the bug.

My bad, sorry.

Just fixing

[mattyw, 2013-10-23 23:04:29]

Please take a look.

[axw, 2013-10-24 05:42:48]

On 2013/10/23 22:58:47, mattyw wrote:
> On 2013/10/23 22:42:20, axw wrote:
> > On 2013/10/23 22:05:20, matthew.williams wrote:
> > > Please take a look.
> > 
> > The lp: points to "Open Rails Tracker". I don't think that's right? :)
> > 
> > Just as a general thing, it's useful to include a description of the fix, as
> > well as a pointer to the bug.
> 
> My bad, sorry.
> 
> Just fixing

No worries! Thanks for fixing the issue.

[axw, 2013-10-24 05:42:58]

https://codereview.appspot.com/15690053/diff/30001/cmd/jujud/machine_test.go
File cmd/jujud/machine_test.go (right):

https://codereview.appspot.com/15690053/diff/30001/cmd/jujud/machine_test.go#...
cmd/jujud/machine_test.go:38: 
Should that be s/test/testing/? IMHO, an alias of lxctesting would be useful,
like envtesting.

https://codereview.appspot.com/15690053/diff/30001/container/lxc/lxc.go
File container/lxc/lxc.go (right):

https://codereview.appspot.com/15690053/diff/30001/container/lxc/lxc.go#newco...
container/lxc/lxc.go:34: 
There's a convention for vars that are exported just for tests. Instead of this,
we do "var containerDir = ..." in this file, and then in a new file called
"export_test.go" have "var ContainerDir = containerDir". That makes it a bit
more obvious why it's exported. If you do that, all the other case changes can
(should) be reverted.

https://codereview.appspot.com/15690053/diff/30001/container/lxc/lxc_test.go
File container/lxc/lxc_test.go (right):

https://codereview.appspot.com/15690053/diff/30001/container/lxc/lxc_test.go#...
container/lxc/lxc_test.go:35: 
testing/lxctesting?

https://codereview.appspot.com/15690053/diff/30001/container/lxc/testing/test.go
File container/lxc/testing/test.go (right):

https://codereview.appspot.com/15690053/diff/30001/container/lxc/testing/test...
container/lxc/testing/test.go:4: // Functions defined in this file should *ONLY*
be used for testing.  These
I think this comment is kinda redundant now; this can be inferred from its
package.

https://codereview.appspot.com/15690053/diff/30001/provider/local/environprov...
File provider/local/environprovider_test.go (right):

https://codereview.appspot.com/15690053/diff/30001/provider/local/environprov...
provider/local/environprovider_test.go:16: 
testing/lxctesting?

https://codereview.appspot.com/15690053/diff/30001/worker/provisioner/lxc-bro...
File worker/provisioner/lxc-broker_test.go (right):

https://codereview.appspot.com/15690053/diff/30001/worker/provisioner/lxc-bro...
worker/provisioner/lxc-broker_test.go:33: 
testing/lxctesting?

[mattyw, 2013-10-28 13:26:40]

Please take a look.

[mattyw, 2013-10-28 13:43:03]

Please take a look.

[mattyw, 2013-10-28 13:58:40]

On 2013/10/28 13:26:40, mattyw wrote:
> Please take a look.

I'm not able to use the export_test model because the lxc testing package is
used by tests in other packages

[axw, 2013-10-31 05:23:06]

On 2013/10/28 13:58:40, mattyw wrote:
> On 2013/10/28 13:26:40, mattyw wrote:
> > Please take a look.
> 
> I'm not able to use the export_test model because the lxc testing package is
> used by tests in other packages

Ah, of course, sorry. LGTM. Thanks for fixing this.

[mattyw, 2013-11-11 10:58:50]

Please take a look.