Issue 15690052: Get tools metadata from streams.canonical.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15690052: Get tools metadata from streams.canonical.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by wallyworld

Modified:
10 years, 6 months ago

Reviewers:
mp+192354, fwereade

Visibility:
Public.

Description

Get tools metadata from streams.canonical.com This branch removes all of the hard coded cloud specific tools metadata urls and instead uses streams.canonical.com as the source for tools metadata. The deprecated public bucket url config item is also removed. https://code.launchpad.net/~wallyworld/juju-core/simplestreams-repository/+merge/192354 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -238 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/mongo_test.go	View	1 chunk	+0 lines, -32 lines	1 comment	Download
M	environs/sync/sync.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	environs/tools/simplestreams.go	View	5 chunks	+2 lines, -20 lines	0 comments	Download
M	environs/tools/urls_test.go	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	provider/azure/environ.go	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	provider/azure/environ_test.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	provider/dummy/environs.go	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	provider/ec2/ec2.go	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	provider/ec2/local_test.go	View	1 chunk	+1 line, -4 lines	0 comments	Download
D	provider/openstack/certifiedclouds.go	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	provider/openstack/certifiedclouds_test.go	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	provider/openstack/config.go	View	3 chunks	+0 lines, -11 lines	0 comments	Download
M	provider/openstack/config_test.go	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	provider/openstack/export_test.go	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	provider/openstack/live_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/openstack/local_test.go	View	2 chunks	+1 line, -53 lines	0 comments	Download
M	provider/openstack/provider.go	View	1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

LGTM pending actual existence of streams.canonical.com and suitable live testing. https://codereview.appspot.com/15690052/diff/1/environs/mongo_test.go File environs/mongo_test.go (left): https://codereview.appspot.com/15690052/diff/1/environs/mongo_test.go#oldcode43 ...

10 years, 6 months ago (2013-10-24 18:10:32 UTC) #2

wallyworld

10 years, 6 months ago (2013-10-26 00:24:59 UTC) #3

On 2013/10/24 18:10:32, fwereade wrote:
> LGTM pending actual existence of http://streams.canonical.com and suitable
live
> testing.
> 
> https://codereview.appspot.com/15690052/diff/1/environs/mongo_test.go
> File environs/mongo_test.go (left):
> 
>
https://codereview.appspot.com/15690052/diff/1/environs/mongo_test.go#oldcode43
> environs/mongo_test.go:43: return
> environs.MongoStoragePath(version.Current.Series, version.Current.Arch)
> What's this for if it's no longer tested? Can we just drop MongoStoragePath
> entirely? (is this already in a followup? ;p)

Yes, this was deleted in the next branch

Expand All Messages | Collapse All Messages