Issue 156330043: code review 156330043: encoding/gob: fix print format in generate decoder helpers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 156330043: code review 156330043: encoding/gob: fix print format in generate decoder helpers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by r

Modified:
10 years, 4 months ago

Reviewers:
adg

CC:
golang-codereviews, adg

Visibility:
Public.

Description

encoding/gob: fix print format in generated decoder helpers Needed a %% to quote a percent in the format.

Patch Set 1 #

Patch Set 2 : diff -r 8ff3b7315209f22151ed3c2655e952ff8344381d https://code.google.com/p/go/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
	M	src/encoding/gob/dec_helpers.go	View		16 chunks	+16 lines, -16 lines	0 comments	Download
	M	src/encoding/gob/decgen.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 5 months ago (2014-10-18 05:07:39 UTC) #1

10 years, 4 months ago (2014-10-19 13:44:55 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a68abe0de054 ***

encoding/gob: fix print format in generated decoder helpers
Needed a %% to quote a percent in the format.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://codereview.appspot.com/156330043

Expand All Messages | Collapse All Messages