Issue 156082: recent changes to tools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 156082: recent changes to tools (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by woodie

Modified:
1 year, 4 months ago

Reviewers:
do_not_use

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : replace all files for JavaClass #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
M	appengine-tools/Rakefile	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	appengine-tools/lib/appengine-tools/gem_bundler.rb	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	google-appengine/Rakefile	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	google-appengine/google_appengine.rb	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	jruby-abridged/Rakefile	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	jruby-abridged/lib/appengine-jruby-jars.rb	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

woodie

I'd like to get a version out that works with Rails 3 http://codereview.appspot.com/156082/diff/1/3 File appengine-tools/lib/appengine-tools/gem_bundler.rb ...

13 years, 6 months ago (2009-11-18 19:57:31 UTC) #1

woodie

per Charlie's feedback, I created my own JavaClass org/jruby/javasupport/JavaClass.java // if (!Ruby.isSecurityRestricted()) { // try ...

13 years, 6 months ago (2009-11-18 20:03:29 UTC) #2

this is a similar snapshot to 150058

Expand All Messages | Collapse All Messages