Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1246)

Issue 156047: asn1: add Marshal. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by agl1
Modified:
14 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

asn1: * add Marshal * add BitString.RightAlign * change to using a *time.Time (from time.Time) since that's what the time package uses. * return the unparsed data from Unmarshal.

Patch Set 1 #

Patch Set 2 : code review 156047: asn1: #

Total comments: 12

Patch Set 3 : code review 156047: asn1: #

Patch Set 4 : code review 156047: asn1: #

Patch Set 5 : code review 156047: asn1: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+705 lines, -161 lines) Patch
M src/pkg/asn1/Makefile View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/asn1/asn1.go View 1 2 3 9 chunks +31 lines, -134 lines 0 comments Download
M src/pkg/asn1/asn1_test.go View 8 chunks +53 lines, -26 lines 0 comments Download
A src/pkg/asn1/common.go View 1 chunk +140 lines, -0 lines 0 comments Download
A src/pkg/asn1/marshal.go View 1 chunk +400 lines, -0 lines 0 comments Download
A src/pkg/asn1/marshal_test.go View 1 chunk +78 lines, -0 lines 0 comments Download
M src/pkg/crypto/x509/x509.go View 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
agl1
14 years, 8 months ago (2009-11-17 21:52:21 UTC) #1
rsc
LGTM http://codereview.appspot.com/156047/diff/14/1001 File src/pkg/asn1/Makefile (right): http://codereview.appspot.com/156047/diff/14/1001#newcode11 src/pkg/asn1/Makefile:11: serialise.go\ Sorry, american spelling please. (I have nothing ...
14 years, 8 months ago (2009-11-18 01:04:54 UTC) #2
agl1
http://codereview.appspot.com/156047/diff/14/1001 File src/pkg/asn1/Makefile (right): http://codereview.appspot.com/156047/diff/14/1001#newcode11 src/pkg/asn1/Makefile:11: serialise.go\ On 2009/11/18 01:04:54, rsc wrote: > Sorry, american ...
14 years, 8 months ago (2009-11-18 02:06:28 UTC) #3
agl1
14 years, 8 months ago (2009-11-18 02:09:41 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=aeb5dd24d1fe ***

asn1:
  * add Marshal
  * add BitString.RightAlign
  * change to using a *time.Time (from time.Time) since that's what
    the time package uses.
  * return the unparsed data from Unmarshal.

R=rsc
CC=golang-dev
http://codereview.appspot.com/156047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b