code review 15570046: test/mapnan: use time.Now instead of syscall.Getrusage

test/mapnan: use time.Now instead of syscall.Getrusage

Avoids a dependency on a somewhat nonstandard part of package syscall.

[rsc, 2013-10-22 16:33:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2013-10-22 16:38:02]

LGTM.

On Wed, Oct 23, 2013 at 3:33 AM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> test/mapnan: use time.Now instead of syscall.Getrusage
>
> Avoids a dependency on a somewhat nonstandard part of package syscall.
>
> Please review this at https://codereview.appspot.com/15570046/
>
> Affected files (+2, -10 lines):
>   M test/mapnan.go
>
>
> Index: test/mapnan.go
> ===================================================================
> --- a/test/mapnan.go
> +++ b/test/mapnan.go
> @@ -13,17 +13,13 @@
>         "fmt"
>         "math"
>         "time"
> -       "syscall"
>  )
>
>  func main() {
>
>         // Test that NaNs in maps don't go quadratic.
>         t := func(n int) time.Duration {
> -               var u0 syscall.Rusage
> -               if err := syscall.Getrusage(0,  &u0); err != nil {
> -                       panic(err)
> -               }
> +               t1 := time.Now()
>                 m := map[float64]int{}
>                 nan := math.NaN()
>                 for i := 0; i < n; i++ {
> @@ -32,11 +28,7 @@
>                 if len(m) != n {
>                         panic("wrong size map after nan insertion")
>                 }
> -               var u1 syscall.Rusage
> -               if err := syscall.Getrusage(0,  &u1); err != nil {
> -                       panic(err)
> -               }
> -               return time.Duration(u1.Utime.Nano() - u0.Utime.Nano())
> +               return time.Since(t1)
>         }
>
>         // Depending on the machine and OS, this test might be too fast
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[r, 2013-10-22 16:49:38]

LGTM

[rsc, 2013-10-22 22:33:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=9169cb38c3e8 ***

test/mapnan: use time.Now instead of syscall.Getrusage

Avoids a dependency on a somewhat nonstandard part of package syscall.

R=golang-dev, dave, r
CC=golang-dev
https://codereview.appspot.com/15570046