Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(166)

Issue 155620045: code review 155620045: time: panic with a more helpful error on use of invalid... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by bradfitz
Modified:
6 years, 3 months ago
Reviewers:
rsc
CC:
r, rsc, golang-codereviews
Visibility:
Public.

Description

time: panic with a more helpful error on use of invalid Timer Fixes Issue 8721

Patch Set 1 #

Patch Set 2 : diff -r 440c1cc9f5d6c5a00b038889476a5e2f6bfced1f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 440c1cc9f5d6c5a00b038889476a5e2f6bfced1f https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 440c1cc9f5d6c5a00b038889476a5e2f6bfced1f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/time/sleep.go View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M src/time/sleep_test.go View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello r@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
6 years, 3 months ago (2014-10-21 07:56:30 UTC) #1
rsc
LGTM thanks https://codereview.appspot.com/155620045/diff/40001/src/time/sleep.go File src/time/sleep.go (right): https://codereview.appspot.com/155620045/diff/40001/src/time/sleep.go#newcode59 src/time/sleep.go:59: panic("Stop called on uninitialized Timer") s/"/"time: / ...
6 years, 3 months ago (2014-10-21 11:15:17 UTC) #2
bradfitz
6 years, 3 months ago (2014-10-21 11:27:02 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=7e89fedb40e6 ***

time: panic with a more helpful error on use of invalid Timer

Fixes Issue 8721

LGTM=rsc
R=r, rsc
CC=golang-codereviews
https://codereview.appspot.com/155620045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b