Issue 155360043: code review 155360043: runtime: handle all windows exception (second attempt)

Issue 155360043: code review 155360043: runtime: handle all windows exception (second attempt) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by brainman

Modified:
10 years, 5 months ago

Reviewers:
gobot, rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

runtime: handle all windows exception (second attempt) includes undo of 22318cd31d7d and also: - always use SetUnhandledExceptionFilter on windows-386; - crash when receive EXCEPTION_BREAKPOINT in exception handler. Fixes issue 8006.

Patch Set 1 #

Patch Set 2 : diff -r 0ca77a6b76c1a990f7c01ba84381bc95ae8cbc81 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0ca77a6b76c1a990f7c01ba84381bc95ae8cbc81 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 9825b678db2f351718d17ce527f4b1713100243d https://go.googlecode.com/hg/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -72 lines)			Patch
M	src/runtime/defs_windows.go	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/runtime/defs_windows_386.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/runtime/defs_windows_amd64.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/runtime/os_windows.c	View	1 2 3	7 chunks	+32 lines, -6 lines	0 comments	Download
M	src/runtime/os_windows_386.c	View	1	2 chunks	+49 lines, -31 lines	0 comments	Download
M	src/runtime/os_windows_amd64.c	View	1	2 chunks	+62 lines, -31 lines	0 comments	Download
M	src/runtime/sys_windows_386.s	View	1	4 chunks	+16 lines, -2 lines	0 comments	Download
M	src/runtime/sys_windows_amd64.s	View	1	4 chunks	+16 lines, -2 lines	0 comments	Download
M	src/runtime/syscall_windows_test.go	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 5 months ago (2014-10-14 01:38:36 UTC) #1

rsc

LGTM https://codereview.appspot.com/155360043/diff/40001/src/runtime/os_windows.c File src/runtime/os_windows.c (right): https://codereview.appspot.com/155360043/diff/40001/src/runtime/os_windows.c#newcode113 src/runtime/os_windows.c:113: void *addVectoredContinueHandler = nil; move initialization down into ...

10 years, 5 months ago (2014-10-14 20:33:02 UTC) #2

brainman

*** Submitted as https://code.google.com/p/go/source/detail?r=aede4cf79f18 *** runtime: handle all windows exception (second attempt) includes undo of ...

10 years, 5 months ago (2014-10-15 00:11:22 UTC) #3

gobot

10 years, 5 months ago (2014-10-15 00:43:00 UTC) #4

Message was sent while issue was closed.

This changed caused perf changes on windows-amd64-perf:


garbage-1                 old          new      delta
cputime              29250000     29687500      +1.50
time                 29184315     29608698      +1.45

garbage-2                 old          new      delta
cputime              29671875     30203125      +1.79
time                 14893429     15105620      +1.42

garbage-4                 old          new      delta
cputime              30500000     31117187      +2.02
time                  7684929      7813045      +1.67

garbage-8                 old          new      delta
cputime              32690625     33368750      +2.07

garbage-16                old          new      delta
cputime              50450000     51596875      +2.27

http://build.golang.org/perfdetail?commit=aede4cf79f18c40b5ec90a9d9580f20687f...



—gobot

Expand All Messages | Collapse All Messages