code review 155190043: debug/elf: add comments explaining applyRelocations for...

debug/elf: add comments explaining applyRelocations for amd64/arm64

[iant, 2014-10-09 19:15:38]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-10-09 20:25:10]

LGTM


On Thu, Oct 9, 2014 at 9:15 PM, <iant@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> debug/elf: add comments explaining applyRelocations for amd64/arm64
>
> Please review this at https://codereview.appspot.com/155190043/
>
> Affected files (+8, -0 lines):
>   M src/debug/elf/file.go
>
>
> Index: src/debug/elf/file.go
> ===================================================================
> --- a/src/debug/elf/file.go
> +++ b/src/debug/elf/file.go
> @@ -564,6 +564,10 @@
>                         continue
>                 }
>
> +               // There are relocations, so this must be a normal
> +               // object file, and we only look at section symbols,
> +               // so we assume that the symbol value is 0.
> +
>                 switch t {
>                 case R_X86_64_64:
>                         if rela.Off+8 >= uint64(len(dst)) || rela.Addend <
> 0 {
> @@ -646,6 +650,10 @@
>                         continue
>                 }
>
> +               // There are relocations, so this must be a normal
> +               // object file, and we only look at section symbols,
> +               // so we assume that the symbol value is 0.
> +
>                 switch t {
>                 case R_AARCH64_ABS64:
>                         if rela.Off+8 >= uint64(len(dst)) || rela.Addend <
> 0 {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[iant, 2014-10-09 21:38:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=55e57258025b ***

debug/elf: add comments explaining applyRelocations for amd64/arm64

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/155190043