Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 15450046: code review 15450046: go.crypto/ssh: only close connection if it was open in ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by hanwen-google
Modified:
5 years, 11 months ago
Reviewers:
dfc
CC:
dfc, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: only close connection if it was open in TestClientUnsupportedKex.

Patch Set 1 #

Patch Set 2 : diff -r e3c12cab1b35 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r e3c12cab1b35 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r e3c12cab1b35 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ssh/client_auth_test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
hanwen-google
Hello dfc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
5 years, 11 months ago (2013-10-23 00:55:36 UTC) #1
hanwen-google
Hello dave@cheney.net, dfc (cc: golang-dev@googlegroups.com), Please take another look.
5 years, 11 months ago (2013-10-23 01:23:32 UTC) #2
dfc
On 2013/10/23 01:23:32, hanwen-google wrote: > Hello mailto:dave@cheney.net, dfc (cc: mailto:golang-dev@googlegroups.com), > > Please take ...
5 years, 11 months ago (2013-10-23 17:11:22 UTC) #3
dfc
5 years, 11 months ago (2013-10-23 17:13:06 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=d11168ee6396&repo=crypto ***

go.crypto/ssh: only close connection if it was open in TestClientUnsupportedKex.

R=dave
CC=golang-dev
https://codereview.appspot.com/15450046

Committer: Dave Cheney <dave@cheney.net>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b