Issue 154440043: code review 154440043: dashboard: separate build and non-build metrics in perf...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154440043: code review 154440043: dashboard: separate build and non-build metrics in perf... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by dvyukov

Modified:
10 years, 6 months ago

Reviewers:
adg

CC:
adg, golang-codereviews, iant, rsc

Visibility:
Public.

Description

dashboard: separate build and non-build metrics in perf dashboard As per Ian request: >> Let's clearly separate the build numbers from the runtime numbers. >> The build numbers are interesting but there are many things that >> affect them. The runtime numbers are presumably stable.

Patch Set 1 #

Patch Set 2 : diff -r 66c25dc17854cba60bef390cb7c7ac6346f38e8b https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 66c25dc17854cba60bef390cb7c7ac6346f38e8b https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 34521336dbf8400818ebfeb99df565070e781151 https://code.google.com/p/go.tools #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	dashboard/app/build/build.go	View	1	2 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com, iant@golang.org, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 6 months ago (2014-10-16 16:26:08 UTC) #1

dvyukov

10 years, 6 months ago (2014-10-17 07:34:33 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=8d42bbce4fd0&repo=tools ***

dashboard: separate build and non-build metrics in perf dashboard
As per Ian request:

>> Let's clearly separate the build numbers from the runtime numbers.
>> The build numbers are interesting but there are many things that
>> affect them.  The runtime numbers are presumably stable.

LGTM=adg
R=adg
CC=golang-codereviews, iant, rsc
https://codereview.appspot.com/154440043

Expand All Messages | Collapse All Messages