Issue 154360048: code review 154360048: cmd/go: set exit status for failing "go generate" run.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154360048: code review 154360048: cmd/go: set exit status for failing "go generate" run. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by r

Modified:
10 years, 4 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/go: set exit status for failing "go generate" run.

Patch Set 2 : diff -r a1d988c922a3f110cb949813ad10f274acfdeef9 https://code.google.com/p/go #

Total comments: 1

Patch Set 3 : diff -r 6d6fbf7dee5bf39f628cd1b2e4108a35955788fe https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/cmd/go/generate.go	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 5 months ago (2014-10-17 17:13:51 UTC) #1

rsc

LGTM https://codereview.appspot.com/154360048/diff/20001/src/cmd/go/generate.go File src/cmd/go/generate.go (right): https://codereview.appspot.com/154360048/diff/20001/src/cmd/go/generate.go#newcode271 src/cmd/go/generate.go:271: // It then exits the program because generation ...

10 years, 4 months ago (2014-10-20 20:25:31 UTC) #2

10 years, 4 months ago (2014-10-20 20:27:45 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=fd9fbde01624 ***

cmd/go: set exit status for failing "go generate" run.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/154360048

Expand All Messages | Collapse All Messages