Issue 154360046: code review 154360046: dashboard: further improve graph view

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154360046: code review 154360046: dashboard: further improve graph view (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dvyukov

Modified:
11 years, 2 months ago

Reviewers:
adg

CC:
adg, golang-codereviews, iant, rsc

Visibility:
Public.

Description

dashboard: further improve graph view 1. Don't interpolate missing data points, instead just use the previous value for missing points. Interpolation hides significant line jumps, making it look like the jump is a result of several small changes. 2. Add annotations for significant changes.

Patch Set 1 #

Patch Set 2 : diff -r ce0e0a1d6a53f367381513713d69a9ec1fa55632 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r ce0e0a1d6a53f367381513713d69a9ec1fa55632 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r dae51f22f25100e2336df2c841c6128d1a033611 https://code.google.com/p/go.tools #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -22 lines)			Patch
	M	dashboard/app/build/perf_graph.go	View	1 2	6 chunks	+13 lines, -21 lines	0 comments	Download
	M	dashboard/app/build/perf_graph.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com, iant@golang.org, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 2 months ago (2014-10-17 07:44:33 UTC) #1

dvyukov

11 years, 2 months ago (2014-10-17 08:17:55 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=0ca87dd384e2&repo=tools ***

dashboard: further improve graph view
1. Don't interpolate missing data points,
instead just use the previous value for missing points.
Interpolation hides significant line jumps,
making it look like the jump is a result of several small changes.
2. Add annotations for significant changes.

LGTM=adg
R=adg
CC=golang-codereviews, iant, rsc
https://codereview.appspot.com/154360046

Expand All Messages | Collapse All Messages