Issue 154360043: code review 154360043: taowm: fix crasher when unmanaging a full-screen window...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154360043: code review 154360043: taowm: fix crasher when unmanaging a full-screen window... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by nigeltao

Modified:
11 years, 3 months ago

Reviewers:

CC:
nigeltao, taowm_googlegroups.com

Visibility:
Public.

Description

taowm: fix crasher when unmanaging a full-screen window on an off-screen workspace.

Patch Set 1 #

Patch Set 2 : diff -r 1eb8a79aa98a796e92b048a0c3fa1e5019cd0ab4 https://code.google.com/p/taowm/ #

Patch Set 3 : diff -r 1eb8a79aa98a796e92b048a0c3fa1e5019cd0ab4 https://code.google.com/p/taowm/ #

Patch Set 4 : diff -r 1eb8a79aa98a796e92b048a0c3fa1e5019cd0ab4 https://code.google.com/p/taowm/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	taowm/actions.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

nigeltao

Hello nigeltao@golang.org (cc: taowm@googlegroups.com), I'd like you to review this change to https://code.google.com/p/taowm/

11 years, 3 months ago (2014-10-15 10:37:01 UTC) #1

nigeltao

11 years, 3 months ago (2014-10-15 10:37:48 UTC) #2

*** Submitted as https://code.google.com/p/taowm/source/detail?r=0c7cc1e7e985
***

taowm: fix crasher when unmanaging a full-screen window on an
off-screen workspace.

TBR=nigeltao
R=nigeltao
CC=taowm
https://codereview.appspot.com/154360043

Expand All Messages | Collapse All Messages