Issue 153950043: code review 153950043: runtime: Check callers in can_recover if return address...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153950043: code review 153950043: runtime: Check callers in can_recover if return address... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by iant

Modified:
9 years, 8 months ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

runtime: Check callers in can_recover if return address doesn't match. Also use __builtin_extract_return_address and tighten up the checks in FFI code. Fixes PR 60406.

Patch Set 1 #

Patch Set 2 : 50bdfe92960f4b78fe2ed3c032cdad64c0b259c1 https://iant%40golang.org@code.google.com/p/gofrontend/ #

Patch Set 3 : 50bdfe92960f4b78fe2ed3c032cdad64c0b259c1 https://iant%40golang.org@code.google.com/p/gofrontend/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+197 lines, -78 lines)			Patch
M	libgo/go/reflect/makefunc_ffi_c.c	View	1 2	2 chunks	+10 lines, -17 lines	0 comments	Download
M	libgo/runtime/go-defer.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	libgo/runtime/go-panic.h	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	libgo/runtime/go-recover.c	View	1 2	3 chunks	+177 lines, -56 lines	0 comments	Download
M	libgo/runtime/panic.c	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://iant%40golang.org@code.google.com/p/gofrontend/

9 years, 8 months ago (2014-10-08 14:02:02 UTC) #1

iant

9 years, 8 months ago (2014-10-08 14:02:15 UTC) #2

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=569e72035892 ***

runtime: Check callers in can_recover if return address	doesn't match.

Also use __builtin_extract_return_address and tighten up the
checks in FFI code.

Fixes PR 60406.

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/153950043

Expand All Messages | Collapse All Messages