code review 153940043: go.tools/dashboard/builder: make old commit watcher opt...

go.tools/dashboard/builder: make old commit watcher opt-in and exclusive

Only gccgo should be using this now, and hopefully not for too long.
Turn it off by default, and make it the only thing that happens
when it's switched on.

[adg, 2014-10-03 22:05:05]

Hello bradfitz, cmang (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[bradfitz, 2014-10-03 22:08:01]

What's with the go1.3 part?
On Oct 3, 2014 3:05 PM, <adg@golang.org> wrote:

> Reviewers: bradfitz, cmang,
>
> Message:
> Hello bradfitz, cmang (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools/dashboard/builder: make old commit watcher opt-in and exclusive
>
> Only gccgo should be using this now, and hopefully not for too long.
> Turn it off by default, and make it the only thing that happens
> when it's switched on.
>
> Please review this at https://codereview.appspot.com/153940043/
>
> Affected files (+6, -5 lines):
>   M dashboard/builder/main.go
>
>
> Index: dashboard/builder/main.go
> ===================================================================
> --- a/dashboard/builder/main.go
> +++ b/dashboard/builder/main.go
> @@ -61,7 +61,7 @@
>         buildTimeout   = flag.Duration("buildTimeout", 60*time.Minute,
> "Maximum time to wait for builds and tests")
>         cmdTimeout     = flag.Duration("cmdTimeout", 10*time.Minute,
> "Maximum time to wait for an external command")
>         commitInterval = flag.Duration("commitInterval", 1*time.Minute,
> "Time to wait between polling for new commits (0 disables commit poller)")
> -       commitOnly     = flag.Bool("commitWatchOnly", false, "only run the
> commit watch loop and don't do any builds")
> +       commitWatch    = flag.Bool("commitWatch", false, "run the commit
> watch loop only (do no builds)")
>         benchNum       = flag.Int("benchnum", 5, "Run each benchmark that
> many times")
>         benchTime      = flag.Duration("benchtime", 5*time.Second,
> "Benchmarking time for a single benchmark run")
>         benchMem       = flag.Int("benchmem", 64, "Approx RSS value to aim
> at in benchmarks, in MB")
> @@ -141,6 +141,7 @@
>         if err != nil {
>                 log.Fatal("Error finding repository:", err)
>         }
> +       rr.VCS.LogCmd += " -b release-branch.go1.3"
>         rootPath := filepath.Join(*buildroot, "goroot")
>         goroot := &Repo{
>                 Path:   rootPath,
> @@ -213,10 +214,10 @@
>                 os.Exit(2)
>         }
>
> -       // Start commit watcher
> -       go commitWatcher(goroot)
> -       if *commitOnly {
> -               select {}
> +       // Start commit watcher.
> +       if *commitWatch {
> +               commitWatcher(goroot)
> +               return
>         }
>
>         // go continuous build mode
>
>
>

[adg, 2014-10-03 22:08:55]

Hello bradfitz@golang.org, cmang@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[adg, 2014-10-03 22:09:22]

On 4 October 2014 08:08, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> What's with the go1.3 part?


debugging dreg; removed

[bradfitz, 2014-10-03 22:12:26]

LGTM
 On Oct 3, 2014 3:09 PM, "Andrew Gerrand" <adg@golang.org> wrote:

>
> On 4 October 2014 08:08, Brad Fitzpatrick <bradfitz@golang.org> wrote:
>
>> What's with the go1.3 part?
>
>
> debugging dreg; removed
>

[cmang, 2014-10-03 22:16:00]

LGTM

[adg, 2014-10-03 22:26:20]

*** Submitted as
https://code.google.com/p/go/source/detail?r=1769aaafc93b&repo=tools ***

go.tools/dashboard/builder: make old commit watcher opt-in and exclusive

Only gccgo should be using this now, and hopefully not for too long.
Turn it off by default, and make it the only thing that happens
when it's switched on.

LGTM=bradfitz, cmang
R=bradfitz, cmang
CC=golang-codereviews
https://codereview.appspot.com/153940043