Issue 153610043: code review 153610043: liblink: require DATA lines to be ordered by offset, wi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153610043: code review 153610043: liblink: require DATA lines to be ordered by offset, wi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rsc

Modified:
11 years, 5 months ago

Reviewers:
r, gobot

CC:
r, golang-codereviews

Visibility:
Public.

Description

liblink: require DATA lines to be ordered by offset, with no overlap The assembler could give a better error, but this one is good enough for now. Fixes issue 8880.

Patch Set 1 #

Patch Set 2 : diff -r 5b0487b727a3fcb2e8262151e95664bd9bfecc28 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5b0487b727a3fcb2e8262151e95664bd9bfecc28 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 60a10bf059e743627c8c0fbca2655c43ae08f488 https://code.google.com/p/go/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
M	include/link.h	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/5a/lex.c	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6a/lex.c	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8a/lex.c	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/liblink/data.c	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 5 months ago (2014-10-15 02:52:05 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=80df44cfde2e *** liblink: require DATA lines to be ordered by offset, with ...

11 years, 5 months ago (2014-10-15 03:25:17 UTC) #3

gobot

11 years, 5 months ago (2014-10-15 05:15:01 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/8e420dc235dfdee64860c0aa171b80e528d6db29

Expand All Messages | Collapse All Messages