Issue 1534042: Get Routes from database

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1534042: Get Routes from database

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by calidion

Modified:
7 years, 4 months ago

Reviewers:
xan, weiliu, baiming, leio.chen, lychen

CC:
xinxing_google.com, lishuangfeng_gmail.com

Base URL:
http://scheduleeditor.googlecode.com/svn/trunk/v2/

Visibility:
Public.

Patch Set 2 : updated #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -17 lines)			Patch
	M	schedule_editor.py	View		1 chunk	+18 lines, -15 lines	0 comments	Download
	M	transitfeed_editor.py	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

weiliu

http://codereview.appspot.com/1534042/diff/1/2 File transitfeed_editor.py (right): http://codereview.appspot.com/1534042/diff/1/2#newcode245 transitfeed_editor.py:245: def GetAll(self, table_name, extra = 1): Rename "extra" to ...

13 years, 11 months ago (2010-06-04 09:23:30 UTC) #2

calidion

13 years, 11 months ago (2010-06-04 09:44:45 UTC) #3

weiliu

LGTM On Fri, Jun 4, 2010 at 5:44 PM, <calidion@gmail.com> wrote: > > http://codereview.appspot.com/1534042/diff/1/2 > ...

13 years, 11 months ago (2010-06-04 09:59:29 UTC) #4

calidion

13 years, 11 months ago (2010-06-04 10:06:06 UTC) #5

updated to rev 87

2010/6/4 Wei Liu <weiliu@google.com>

> LGTM
>
>
> On Fri, Jun 4, 2010 at 5:44 PM, <calidion@gmail.com> wrote:
>
>>
>> http://codereview.appspot.com/1534042/diff/1/2
>> File transitfeed_editor.py (right):
>>
>> http://codereview.appspot.com/1534042/diff/1/2#newcode245
>> transitfeed_editor.py:245: def GetAll(self, table_name, extra = 1):
>> On 2010/06/04 09:23:30, weiliu wrote:
>>
>>> Rename "extra" to "condition"?
>>>
>>
>> Done.
>>
>>
>> http://codereview.appspot.com/1534042/show
>>
>
>
>
> --
> Best Regards,
> Wei Liu
> 86-10-62503256(o)
>

Expand All Messages | Collapse All Messages