Issue 153350043: python-sql: Fix copy/deepcopy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153350043: python-sql: Fix copy/deepcopy (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by ced

Modified:
9 years, 6 months ago

Reviewers:
sharoon.thomas

Visibility:
Public.

- Prevent returning Column on FromItem for magic methods - Allow copy attributes by making them simply private

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -93 lines)			Patch
M	sql/__init__.py	View	20 chunks	+92 lines, -90 lines	0 comments	Download
M	sql/functions.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sql/tests/test_select.py	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 2

LGTM

Tried with my use case as well