Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 15280045: code review 15280045: acme: scroll a directory window when navigating if: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by r
Modified:
10 years, 6 months ago
Reviewers:
CC:
rsc, smckean83
Visibility:
Public.

Description

acme: scroll a directory window when navigating if: - the cursor is on the last line - the navigation would put the cursor over the tag of the following text

Patch Set 1 #

Patch Set 2 : diff -r ec3560a87032 http://code.swtch.com/plan9port #

Patch Set 3 : diff -r ec3560a87032 https://code.google.com/p/plan9port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M plumb/basic View 1 chunk +11 lines, -2 lines 0 comments Download
M plumb/fileaddr View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/acme/text.c View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 4
r
Hello rsc (cc: smckean83@gmail.com), I'd like you to review this change to http://code.swtch.com/plan9port
10 years, 6 months ago (2013-10-22 23:46:15 UTC) #1
r
*** Submitted as https://code.google.com/p/plan9port/source/detail?r=c1c9359cfee8 *** acme: scroll a directory window when navigating if: - the ...
10 years, 6 months ago (2013-10-22 23:47:56 UTC) #2
rsc
you checked in a change to plumb/basic too. probably unintended, but probably worth keeping.
10 years, 6 months ago (2013-10-23 03:38:24 UTC) #3
r
10 years, 6 months ago (2013-10-23 04:52:44 UTC) #4
Sorry about that - keeps happening to me. After 5 aborts I stopped paying
close attention.

However, the other change is indeed worth keeping.

-rob
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b