Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84)

Issue 152720043: code review 152720043: cmd/yacc: fix handling of tokens that don't start with ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by iant
Modified:
11 years, 1 month ago
Reviewers:
rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

cmd/yacc: fix handling of tokens that don't start with letters CL 149110043 changed yacc to no longer keep a leading space for quoted tokens. That is OK by itself but unfortunately yacc was relying on that leading space to notice which tokens it should not output as const declarations. Add a few such tokens to expr.y, although it won't make any immediate difference as we seem to have no tests for yacc.

Patch Set 1 #

Patch Set 2 : diff -r 9472d0e26c23a691539de7cf0a81b6c3a569455a https://code.google.com/p/go #

Patch Set 3 : diff -r 805a5313462bec71422395186ffff7155f289b8a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/cmd/yacc/testdata/expr/expr.y View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/yacc/yacc.go View 1 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2014-09-29 02:32:22 UTC) #1
iant
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), Please take another look.
11 years, 1 month ago (2014-09-29 20:19:50 UTC) #2
rsc
LGTM
11 years, 1 month ago (2014-09-29 20:29:03 UTC) #3
iant
11 years, 1 month ago (2014-09-29 20:32:18 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=2c8bf1d7cdd6 ***

cmd/yacc: fix handling of tokens that don't start with letters

CL 149110043 changed yacc to no longer keep a leading space
for quoted tokens.  That is OK by itself but unfortunately
yacc was relying on that leading space to notice which tokens
it should not output as const declarations.

Add a few such tokens to expr.y, although it won't make any
immediate difference as we seem to have no tests for yacc.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/152720043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b