Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1721)

Issue 152600043: Additions in event-listener.ly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by pkx166h
Modified:
4 weeks ago
CC:
lilypond-devel_gnu.org, phil Hezaine
Visibility:
Public.

Description

Issue 4164 Additions in event-listener.ly Changes applied to DrumVoice, drum-type... Patch provided by Phil Hezaine

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebased to current master - comment by VV not yet addressed #

Patch Set 3 : With Thomas' corrections - thanks Thomas. #

Total comments: 2

Patch Set 4 : Trivial typo fix (thanks Marc) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -21 lines) Patch
M ly/event-listener.ly View 1 2 3 2 chunks +34 lines, -21 lines 0 comments Download

Messages

Total messages: 12
Valentin Villenave
Greetings Philippe and James, this looks good overall, I just have one minor comment. https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly ...
2 years, 11 months ago (2014-10-17 06:40:24 UTC) #1
pkx166h
Rebased to current master - comment by VV not yet addressed
6 months ago (2017-03-19 12:32:36 UTC) #2
pkx166h
On 2014/10/17 06:40:24, Valentin Villenave wrote: > Greetings Philippe and James, > this looks good ...
6 months ago (2017-03-22 07:02:43 UTC) #3
dak
https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly File ly/event-listener.ly (right): https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode69 ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment)) Why this change for the ...
6 months ago (2017-03-22 10:24:21 UTC) #4
Graham Percival
On 2017/03/22 10:24:21, dak wrote: > ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment)) > Why this change ...
6 months ago (2017-03-23 00:55:21 UTC) #5
pkx166h
Thanks to David (and Graham). I understand David's comments but don't have the knowledge (or ...
5 months, 4 weeks ago (2017-03-25 10:34:02 UTC) #6
thomasmorley651
On 2017/03/25 10:34:02, pkx166h wrote: > Thanks to David (and Graham). > > I understand ...
5 months, 3 weeks ago (2017-03-25 22:31:36 UTC) #7
pkx166h
With Thomas' corrections - thanks Thomas.
1 month, 1 week ago (2017-08-12 09:35:52 UTC) #8
marc
Just a nitpick ... https://codereview.appspot.com/152600043/diff/40001/ly/event-listener.ly File ly/event-listener.ly (right): https://codereview.appspot.com/152600043/diff/40001/ly/event-listener.ly#newcode220 ly/event-listener.ly:220: (note-event . format-note) ;; works ...
1 month ago (2017-08-14 20:36:08 UTC) #9
pkx166h
Trivial typo fix (thanks Marc)
1 month ago (2017-08-15 06:54:06 UTC) #10
pkx166h
https://codereview.appspot.com/152600043/diff/40001/ly/event-listener.ly File ly/event-listener.ly (right): https://codereview.appspot.com/152600043/diff/40001/ly/event-listener.ly#newcode220 ly/event-listener.ly:220: (note-event . format-note) ;; works for On 2017/08/14 20:36:07, ...
1 month ago (2017-08-15 06:54:59 UTC) #11
pkx166h
4 weeks ago (2017-08-22 09:08:11 UTC) #12
author	Thomas Morley <thomasmorley65@gmail.com>	
	Sat, 12 Aug 2017 10:34:42 +0100 (10:34 +0100)
committer	James Lowe <pkx166h@gmail.com>	
	Tue, 22 Aug 2017 10:04:17 +0100 (10:04 +0100)
commit	f0781fa82140814e371275e84802b3648970477a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted