LGTM On Wed, Oct 15, 2014 at 7:39 AM, <iant@golang.org> wrote: > Reviewers: agl, > ...
9 years, 6 months ago
(2014-10-15 05:48:04 UTC)
#2
LGTM
On Wed, Oct 15, 2014 at 7:39 AM, <iant@golang.org> wrote:
> Reviewers: agl,
>
> Message:
> Hello agl (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> crypto/x509: correct field name in comment
>
> Fixes issue 8936.
>
> Please review this at https://codereview.appspot.com/152590043/
>
> Affected files (+1, -1 lines):
> M src/crypto/x509/x509.go
>
>
> Index: src/crypto/x509/x509.go
> ===================================================================
> --- a/src/crypto/x509/x509.go
> +++ b/src/crypto/x509/x509.go
> @@ -1670,7 +1670,7 @@
>
> // CreateCertificateRequest creates a new certificate based on a
> template. The
> // following members of template are used: Subject, Attributes,
> -// SignatureAlgorithm, Extension, DNSNames, EmailAddresses, and
> IPAddresses.
> +// SignatureAlgorithm, Extensions, DNSNames, EmailAddresses, and
> IPAddresses.
> // The private key is the private key of the signer.
> //
> // The returned slice is the certificate request in DER encoding.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
*** Submitted as https://code.google.com/p/go/source/detail?r=fdd1b556fd14 *** crypto/x509: correct field name in comment Fixes issue 8936. LGTM=bradfitz ...
9 years, 6 months ago
(2014-10-15 13:21:02 UTC)
#3
Issue 152590043: code review 152590043: crypto/x509: correct field name in comment
(Closed)
Created 9 years, 6 months ago by iant
Modified 9 years, 6 months ago
Reviewers:
Base URL:
Comments: 0