Issue 152220044: code review 152220044: cmd/go: fix 'go vet' of package with external tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152220044: code review 152220044: cmd/go: fix 'go vet' of package with external tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by rsc

Modified:
10 years, 4 months ago

Reviewers:
r, gobot, jscrockett01

CC:
golang-codereviews, r, iant

Visibility:
Public.

Description

cmd/go: fix 'go vet' of package with external tests For example, fixes 'go vet syscall', which has source files in package syscall_test. Fixes issue 8511.

Patch Set 1 #

Patch Set 2 : diff -r 38965cf3cec663c0aff7b1ab8fb2c663d592c3df https://code.google.com/p/go/ #

Patch Set 3 : diff -r 38965cf3cec663c0aff7b1ab8fb2c663d592c3df https://code.google.com/p/go/ #

Patch Set 4 : diff -r 38965cf3cec663c0aff7b1ab8fb2c663d592c3df https://code.google.com/p/go/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -5 lines)			Patch
M	src/cmd/go/test.bash	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
A	src/cmd/go/testdata/src/vetpkg/a_test.go	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/cmd/go/testdata/src/vetpkg/b.go	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/cmd/go/vet.go	View	1	2 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

10 years, 5 months ago (2014-10-06 18:36:55 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=25ea6fb44f62 *** cmd/go: fix 'go vet' of package with external tests For ...

10 years, 5 months ago (2014-10-06 18:49:28 UTC) #3

gobot

This CL appears to have broken the plan9-amd64-aram builder. See http://build.golang.org/log/6a904f09d58a03c7ccbcfa36d95f8e1d20a21ce4

10 years, 5 months ago (2014-10-06 18:50:25 UTC) #4

Message was sent while issue was closed.

FYI this also resolves golang.org/issue/6389 .

Expand All Messages | Collapse All Messages