Issue 152200043: code review 152200043: go.sys/windows: keep windows syscall pointers live

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152200043: code review 152200043: go.sys/windows: keep windows syscall pointers live (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by brainman

Modified:
10 years, 9 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

go.sys/windows: keep windows syscall pointers live apply latest changes made to syscall/mksyscall_windows.go

Patch Set 1 #

Patch Set 2 : diff -r ecdb7cd81cdea5c8a54d6af1d93ff5b149059597 https://code.google.com/p/go.sys #

Patch Set 3 : diff -r ecdb7cd81cdea5c8a54d6af1d93ff5b149059597 https://code.google.com/p/go.sys #

Patch Set 4 : diff -r ecdb7cd81cdea5c8a54d6af1d93ff5b149059597 https://code.google.com/p/go.sys #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -7 lines)			Patch
	M	windows/Makefile	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	windows/zsyscall_windows.go	View	1	6 chunks	+30 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.sys

10 years, 9 months ago (2014-10-05 23:28:39 UTC) #1

brainman

10 years, 9 months ago (2014-10-05 23:49:04 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=0cb744d62783&repo=sys ***

go.sys/windows: keep windows syscall pointers live

apply latest changes made to syscall/mksyscall_windows.go

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/152200043

Expand All Messages | Collapse All Messages