code review 152150043: go.tools/dashboard/app: fix integration tests

go.tools/dashboard/app: fix integration tests

They had been broken after a few recent changes.

[adg, 2014-10-03 22:22:51]

Hello bradfitz (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[bradfitz, 2014-10-03 22:30:48]

LGTM
 On Oct 3, 2014 3:22 PM, <adg@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools/dashboard/app: fix integration tests
>
> They had been broken after a few recent changes.
>
> Please review this at https://codereview.appspot.com/152150043/
>
> Affected files (+6, -4 lines):
>   M dashboard/app/build/test.go
>
>
> Index: dashboard/app/build/test.go
> ===================================================================
> --- a/dashboard/app/build/test.go
> +++ b/dashboard/app/build/test.go
> @@ -72,10 +72,10 @@
>         res  interface{}
>  }{
>         // Packages
> -       {"/packages?kind=subrepo", nil, nil, []*Package{testPackage}},
> +       {"/packages", url.Values{"kind": {"subrepo"}}, nil,
> []*Package{testPackage}},
>
>         // Go repo
> -       {"/commit", nil, tCommit("0001", "0000", "", true), nil},
> +       {"/commit", nil, tCommit("0001", "", "", true), nil},
>         {"/commit", nil, tCommit("0002", "0001", "", false), nil},
>         {"/commit", nil, tCommit("0003", "0002", "", true), nil},
>         {"/todo", url.Values{"kind": {"build-go-commit"}, "builder":
> {"linux-386"}}, nil, &Todo{Kind: "build-go-commit", Data: &Commit{Hash:
> "0003"}}},
> @@ -119,7 +119,7 @@
>         {"/result", nil, &Result{Builder: "linux-386", Hash: "0003", OK:
> false, Log: "test"}, nil},
>
>         // non-Go repos
> -       {"/commit", nil, tCommit("1001", "1000", testPkg, false), nil},
> +       {"/commit", nil, tCommit("1001", "", testPkg, false), nil},
>         {"/commit", nil, tCommit("1002", "1001", testPkg, false), nil},
>         {"/commit", nil, tCommit("1003", "1002", testPkg, false), nil},
>         {"/todo", url.Values{"kind": {"build-package"}, "builder":
> {"linux-386"}, "packagePath": {testPkg}, "goHash": {"0001"}}, nil,
> &Todo{Kind: "build-package", Data: &Commit{Hash: "1003"}}},
> @@ -256,7 +256,9 @@
>                 }
>                 url := "http://" + domain + t.path
>                 if t.vals != nil {
> -                       url += "?" + t.vals.Encode()
> +                       url += "?" + t.vals.Encode() + "&version=2"
> +               } else {
> +                       url += "?version=2"
>                 }
>                 req, err := http.NewRequest("POST", url, body)
>                 if err != nil {
>
>
>

[adg, 2014-10-03 22:33:56]

*** Submitted as
https://code.google.com/p/go/source/detail?r=6d1e3c60ecab&repo=tools ***

go.tools/dashboard/app: fix integration tests

They had been broken after a few recent changes.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/152150043