Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1343)

Issue 152138: code review 152138: Build changes to support work on the BSDs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by dho
Modified:
1 year, 3 months ago
Reviewers:
myexamples04, rsc
CC:
myexamples04
Visibility:
Public.

Description

Build changes to support work on the BSDs. This does still contain some FreeBSD-specific bits, but it's a pain to do partial diffs.

Patch Set 1 #

Patch Set 2 : code review 152138: Initial (very broken) FreeBSD porting work. Re-submit d... #

Patch Set 3 : code review 152138: Initial (very broken) FreeBSD porting work. Re-submit d... #

Patch Set 4 : code review 152138: Initial (very broken) FreeBSD porting work. Re-submit d... #

Total comments: 16

Patch Set 5 : code review 152138: Initial (very broken) FreeBSD porting work. Re-submit d... #

Patch Set 6 : code review 152138: Initial (very broken) FreeBSD porting work. Re-submit d... #

Patch Set 7 : code review 152138: Initial (very broken) FreeBSD porting work. Re-submit d... #

Total comments: 7

Patch Set 8 : code review 152138: Build changes to support work on the BSDs. #

Patch Set 9 : code review 152138: Build changes to support work on the BSDs. #

Patch Set 10 : code review 152138: Build changes to support work on the BSDs. #

Total comments: 4

Patch Set 11 : code review 152138: Build changes to support work on the BSDs. #

Patch Set 12 : code review 152138: Build changes to support work on the BSDs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -48 lines) Patch
M src/Make.pkg View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/all.bash View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/all-arm.bash View 1 chunk +1 line, -1 line 0 comments Download
M src/all-nacl.bash View 1 chunk +1 line, -1 line 0 comments Download
M src/clean.bash View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/clean.bash View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/gofmt/test.sh View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gotest/gotest View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M src/cmd/make.bash View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M src/make.bash View 1 2 3 4 5 6 7 4 chunks +11 lines, -3 lines 0 comments Download
M src/make-arm.bash View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/Makefile View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M src/pkg/deps.bash View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/eval/test.bash View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mkall.sh View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M src/pkg/syscall/mkerrors.sh View 2 chunks +6 lines, -1 line 0 comments Download
M src/quietgcc.bash View 1 chunk +1 line, -1 line 0 comments Download
M src/run.bash View 1 2 3 4 3 chunks +17 lines, -17 lines 0 comments Download
M src/sudo.bash View 1 chunk +1 line, -1 line 0 comments Download
M test/run View 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14
dho
Hello rsc, I'd like you to review the following change.
14 years, 8 months ago (2009-11-14 05:51:27 UTC) #1
rsc
Thanks for doing this! Some comments on the integration aspects. I haven't looked carefully at ...
14 years, 8 months ago (2009-11-14 06:18:53 UTC) #2
dho
Hello rsc, I'd like you to review the following change.
14 years, 8 months ago (2009-11-14 14:29:11 UTC) #3
dho
On 2009/11/14 06:18:53, rsc wrote: > Thanks for doing this! No problem; it's fun! > ...
14 years, 8 months ago (2009-11-14 14:31:15 UTC) #4
rsc
I suggest deleting this file and just writing it directly from the script.
14 years, 8 months ago (2009-11-14 16:00:30 UTC) #5
rsc
Some comments about make. Try running "hg sync --local" (or just hg sync if you ...
14 years, 8 months ago (2009-11-14 16:08:38 UTC) #6
rsc
I'm happy with the build fixes and they seem like a good logical piece to ...
14 years, 8 months ago (2009-11-14 16:12:48 UTC) #7
rsc
http://codereview.appspot.com/152138/diff/1336/1372 File src/pkg/runtime/freebsd/thread.c (right): http://codereview.appspot.com/152138/diff/1336/1372#newcode14 src/pkg/runtime/freebsd/thread.c:14: if(psema != 0) return; split return onto next line ...
14 years, 8 months ago (2009-11-14 16:27:12 UTC) #8
dho
Hello rsc, I'd like you to review the following change.
14 years, 8 months ago (2009-11-14 17:49:37 UTC) #9
rsc
Thanks, looks good. cd $GOROOT/src hg file -d 152138 cmd/cov/Makefile cmd/prof/Makefile libcgo/Makefile Have you done ...
14 years, 8 months ago (2009-11-14 19:56:22 UTC) #10
dho
Hello rsc, I'd like you to review the following change.
14 years, 8 months ago (2009-11-14 23:17:05 UTC) #11
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=692ac2ced6f7 *** Build changes to support work on the BSDs. This does ...
14 years, 8 months ago (2009-11-14 23:29:11 UTC) #12
myexamples04
1 year, 3 months ago (2023-04-23 15:31:49 UTC) #13
myexamples04
1 year, 3 months ago (2023-04-23 15:33:30 UTC) #14
Message was sent while issue was closed.
Hello hello hello kopi dan milo
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b