vary header handling for httplib2

A naive approach to handling Vary headers in httplib2's caching.

This is a quick fix, presumably much can be improved. It's certainly not DRY.

The basic idea is that when a resource is cached, it is annotated with information about which headers are listed in the Vary header (if present). In subsequent requests the cache is only valid if those variant headers are the same.

[jcgregorio, 2009-11-11 22:17:05]

Please add tests to httplib2test.py. Also, please mirror all these changes,
including the tests, to the python3 version of the code.

http://codereview.appspot.com/152062/diff/1/2
File httplib2/__init__.py (right):

http://codereview.appspot.com/152062/diff/1/2#newcode379
httplib2/__init__.py:379: key = 'varied-%s' % header
Please change "varied-" to "-varied-", that is, prefix such headers with "-"
since that's illegal in a normal HTTP header. I did the same thing for
"-content-encoding" which records the historical value for content-encoding
before it was unzipped.

[cdent, 2009-11-13 13:51:33]

On 2009/11/11 22:17:05, jcgregorio wrote:
> Please add tests to httplib2test.py. Also, please mirror all these changes,
> including the tests, to the python3 version of the code.

This patch set  (2) is for python2, so far. I added tests, and did the -varied
change and changed the way tail is called. I used the more commonly available -n
+2 instead of --lines=+2


Otherwise I could not run the tests.

python3 in a bit.

[cdent, 2009-11-13 13:54:33]

On 2009/11/13 13:51:33, cdent wrote:
> On 2009/11/11 22:17:05, jcgregorio wrote:
> > Please add tests to httplib2test.py. Also, please mirror all these changes,
> > including the tests, to the python3 version of the code.
> 
> This patch set  (2) is for python2, so far. I added tests, and did the -varied
> change and changed the way tail is called. I used the more commonly available
-n
> +2 instead of --lines=+2
> 
> 
> Otherwise I could not run the tests.
> 
> python3 in a bit.

sorry, checked in localhost settings in the test file.
will do a full patch when python3 is done

[jcgregorio, 2009-12-24 14:58:06]

Ping. I've got the whole python2/python3 distribution issue fixed and would like
to do a release soon, do you want to try to get this change in that release?

[cdent, 2009-12-24 16:16:14]

On Thu, 24 Dec 2009, joe.gregorio@gmail.com wrote:

> Ping. I've got the whole python2/python3 distribution issue fixed and
> would like to do a release soon, do you want to try to get this change
> in that release?
>
> http://codereview.appspot.com/152062

Sure, what needs to happen next?

[jcgregorio, 2009-12-24 20:06:53]

Sorry, I misread your previous message and thought there was still changes you
wanted to make. 

Tested and now committed. 

I did have to rollback the changes on the usage of tail in the .asis files from
"-n +2" to "--lines=+2", because the former doesn't work on my hosting provider.

   Thanks,
   -joe

On 2009/12/24 16:16:14, cdent wrote:
> On Thu, 24 Dec 2009, mailto:joe.gregorio@gmail.com wrote:
> 
> > Ping. I've got the whole python2/python3 distribution issue fixed and
> > would like to do a release soon, do you want to try to get this change
> > in that release?
> >
> > http://codereview.appspot.com/152062
> 
> Sure, what needs to happen next?
>