code review 152060043: reflect: add direct call tests to TestMakeFuncVariadic

reflect: add direct call tests to TestMakeFuncVariadic

TestMakeFuncVariadic only called the variadic function via Call and
CallSlice, not via a direct function call.

I thought these tests would fail under gccgo tip, but they don't.  Still seems worth having though.

[mwhudson, 2014-10-03 01:50:34]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[gobot, 2014-10-08 21:36:44]

R=iant@golang.org (assigned by r@golang.org)

[iant, 2014-10-08 22:57:44]

LGTM

[iant, 2014-10-08 22:58:59]

*** Submitted as https://code.google.com/p/go/source/detail?r=411fad125b02 ***

reflect: add direct call tests to TestMakeFuncVariadic

TestMakeFuncVariadic only called the variadic function via Call and
CallSlice, not via a direct function call.

I thought these tests would fail under gccgo tip, but they don't.  Still seems
worth having though.

LGTM=iant
R=golang-codereviews, gobot, iant
CC=golang-codereviews
https://codereview.appspot.com/152060043

Committer: Ian Lance Taylor <iant@golang.org>

[gobot, 2014-10-08 23:17:30]

This CL appears to have broken the android-arm-crawshaw builder.
See http://build.golang.org/log/0e525bc49f3a8538d51b8642da365bdf8c1cd63f

[iant, 2014-10-08 23:42:32]

On Wed, Oct 8, 2014 at 4:17 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the android-arm-crawshaw builder.
> See http://build.golang.org/log/0e525bc49f3a8538d51b8642da365bdf8c1cd63f
>
> https://codereview.appspot.com/152060043/

Looks unrelated.

go_android_exec: adb push
/tmp/go-build920703746/runtime/pprof/_test/pprof.test
/data/local/tmp/goroot/pprof.test-9166-tmp
210 KB/s (2231436 bytes in 10.364s)
go_android_exec: adb shell cp
'/data/local/tmp/goroot/pprof.test-9166-tmp'
'/data/local/tmp/goroot/pprof.test-9166'
go_android_exec: adb shell rm '/data/local/tmp/goroot/pprof.test-9166-tmp'
go_android_exec: adb shell export TMPDIR="/data/local/tmp"; export
GOROOT="/data/local/tmp/goroot"; cd "$GOROOT/src/runtime/pprof";
'/data/local/tmp/goroot/pprof.test-9166' -test.short=true
-test.timeout=360s; echo -n exitcode=$?
--- FAIL: TestCPUProfileMultithreaded (0.42s)
pprof_test.go:165: runtime/pprof_test.cpuHog1: 18
pprof_test.go:165: runtime/pprof_test.cpuHog2: 0
pprof_test.go:179: runtime/pprof_test.cpuHog2 has 0 samples out of 18,
want at least 1, ideally 9
FAIL
exitcode=1go_android_exec: adb shell rm
'/data/local/tmp/goroot/pprof.test-9166'
FAIL runtime/pprof 21.776s