Issue 151960044: code review 151960044: reflect: fix IsValid vs Kind mismatch after Elem of nil...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 151960044: code review 151960044: reflect: fix IsValid vs Kind mismatch after Elem of nil... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by rsc

Modified:
10 years, 5 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

reflect: fix IsValid vs Kind mismatch after Elem of nil interface

Patch Set 1 #

Patch Set 2 : diff -r 15c0b9f59a610db3924112eec0aeb7aa89106384 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 15c0b9f59a610db3924112eec0aeb7aa89106384 https://code.google.com/p/go/ #

Patch Set 4 : diff -r a7bd17009efcf01f11498b655dfe80adfd1bcbbd https://code.google.com/p/go/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	src/reflect/all_test.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
	M	src/reflect/value.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 5 months ago (2014-10-01 20:45:59 UTC) #1

rsc

10 years, 5 months ago (2014-10-01 20:51:36 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=3f6f21d480ee ***

reflect: fix IsValid vs Kind mismatch after Elem of nil interface

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/151960044

Expand All Messages | Collapse All Messages