Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9951)

Issue 151660044: code review 151660044: unicode: added Merge func for creating RangeTables that...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by mpvl
Modified:
9 years, 4 months ago
Reviewers:
CC:
r, golang-codereviews, nigeltao
Visibility:
Public.

Description

unicode: added Merge func for creating RangeTables that are the union of other range tables or just an optimized table from a non-compacted user-created table. Using merged tables can increase performance noticably.

Patch Set 1 #

Patch Set 2 : diff -r 0bee9108569f https://code.google.com/p/go #

Patch Set 3 : diff -r 0bee9108569f https://code.google.com/p/go #

Patch Set 4 : diff -r 0bee9108569f https://code.google.com/p/go #

Patch Set 5 : diff -r 0bee9108569f https://code.google.com/p/go #

Patch Set 6 : diff -r 0bee9108569f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -0 lines) Patch
A src/unicode/merge.go View 1 chunk +257 lines, -0 lines 0 comments Download
A src/unicode/merge_test.go View 1 chunk +184 lines, -0 lines 0 comments Download

Messages

Total messages: 4
mpvl
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2014-10-09 20:41:52 UTC) #1
mpvl
Hello r@golang.org (cc: golang-codereviews@googlegroups.com, nigeltao@golang.org), Please take another look.
9 years, 6 months ago (2014-10-09 20:44:56 UTC) #2
r
Please ping after 1.4 is out. On Thu, Oct 9, 2014 at 1:44 PM, <mpvl@golang.org> ...
9 years, 6 months ago (2014-10-09 21:20:05 UTC) #3
gobot
9 years, 4 months ago (2014-12-19 05:13:59 UTC) #4
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/151660044 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b