code review 151590043: unicode: added In and NotIn methods to RangeTables. Thi...

unicode: added In and NotIn methods to RangeTables. This allows RangeTables
to directly be passed to Remove, Validate and possibly other funcs in the
go.text/runes (see https://codereview.appspot.com/151580043/) or other
go.text packages.

For example, to get a transformer that removes modifiers, one would now write:

        isMn := func(r rune) bool { return unicode.In(r, unicode.Mn) }
        rmMn := runes.Remove(isMn)

With this change it could be rewritten as:

        rmMn := runes.Remove(unicode.Mn.In)

Note: inlining the body of Is in the new In methods seems to increase
performance by about 15%. I havent done so for clarity, but it was one
factor in the decision of adding these methods (versus adding helper funcs
in the runes package, for example) as it will allow for a performance
optimization that otherwise doesn't seem possible.

[mpvl, 2014-10-09 09:44:06]

Hello r@golang.org (cc: golang-codereviews@googlegroups.com,
nigeltao@golang.org),

I'd like you to review this change to
https://code.google.com/p/go

[r, 2014-10-09 14:25:08]

This will have to wait for the 1.5 thaw when the 1.4 release is cut.

Also: You have an old client. The pkg layer in the source is long gone.

[mpvl, 2014-10-09 20:44:14]

On Thu, Oct 9, 2014 at 4:25 PM, <r@golang.org> wrote:

> This will have to wait for the 1.5 thaw when the 1.4 release is cut.
>
No problem. I just wanted to get these CLs out to consider in conjunction
with CL 151580043.


>
> Also: You have an old client. The pkg layer in the source is long gone.
>
Synced and uploaded.


>
> https://codereview.appspot.com/151590043/
>

[gobot, 2014-12-19 05:13:52]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/151590043 is best) in the description in your
new CL.

Thanks very much.