Issue 151280043: code review 151280043: reflect: add tests for variadic method calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 151280043: code review 151280043: reflect: add tests for variadic method calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by iant

Modified:
9 years, 6 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

reflect: add tests for variadic method calls These tests fail when using gccgo. In gccgo using Interface on the value of a method function is implemented using a variant of MakeFunc. That approach did not correctly handle variadic functions.

Patch Set 1 #

Patch Set 2 : diff -r c5ee3f481631a7ddd652722e7dacf59daca12822 https://code.google.com/p/go #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -5 lines)			Patch
	M	src/reflect/all_test.go	View		3 chunks	+49 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 7 months ago (2014-10-02 23:54:36 UTC) #1

iant

9 years, 6 months ago (2014-10-08 22:48:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9b64cd6eefc5 ***

reflect: add tests for variadic method calls

These tests fail when using gccgo.  In gccgo using Interface
on the value of a method function is implemented using a
variant of MakeFunc.  That approach did not correctly handle
variadic functions.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/151280043

Expand All Messages | Collapse All Messages