Issue 15120043: Add trusty to seriesVersions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15120043: Add trusty to seriesVersions.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by curtis

Modified:
10 years, 6 months ago

Reviewers:
gz, mp+191844

Visibility:
Public.

Description

Add trusty to seriesVersions. Added Ubuntu trusty to the seriesVersions that Juju supports. Updated a test to pass when the machine running the test suite gets an updated ubuntu.csv. https://code.launchpad.net/~sinzui/juju-core/add-trusty-series/+merge/191844 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add trusty to seriesVersions. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/simplestreams/simplestreams.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	environs/simplestreams/simplestreams_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

10 years, 6 months ago (2013-10-18 17:32:18 UTC) #2

LGTM.

https://codereview.appspot.com/15120043/diff/1/environs/simplestreams/simples...
File environs/simplestreams/simplestreams_test.go (right):

https://codereview.appspot.com/15120043/diff/1/environs/simplestreams/simples...
environs/simplestreams/simplestreams_test.go:353: series = series[0:4]
So, this test won't fail when new series are picked up from distro-info, good.

Expand All Messages | Collapse All Messages