Issue 151200043: Add MAAS support to quickstart.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 151200043: Add MAAS support to quickstart.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by frankban

Modified:
10 years, 7 months ago

Reviewers:
mp+236713, bac, rharding

Visibility:
Public.

Description

Add MAAS support to quickstart. Also bump version up and update tge default Juju GUI charm URLs used when charmworld cannot be contacted. Tests: `make check`. QA: already done on a live MAAS instance. However, it is possible to just try to create a MAAS environment YAML via the interactive session. https://code.launchpad.net/~frankban/juju-quickstart/maas/+merge/236713 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add MAAS support to quickstart. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -3 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	quickstart/__init__.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	quickstart/models/envs.py	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	quickstart/settings.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	quickstart/tests/models/test_envs.py	View	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bac

On 2014/10/01 13:48:05, frankban wrote: > Please take a look. LGTM. I did the minimal ...

10 years, 7 months ago (2014-10-01 14:07:10 UTC) #2

rharding

LGTM with one bit of feedback on the wording. Thanks! https://codereview.appspot.com/151200043/diff/1/quickstart/models/envs.py File quickstart/models/envs.py (right): https://codereview.appspot.com/151200043/diff/1/quickstart/models/envs.py#newcode678 ...

10 years, 7 months ago (2014-10-01 14:52:15 UTC) #3

frankban

*** Submitted: Add MAAS support to quickstart. Also bump version up and update tge default ...

10 years, 7 months ago (2014-10-01 15:32:02 UTC) #4

frankban

10 years, 7 months ago (2014-10-01 15:32:44 UTC) #5

Thanks for the reviews!

https://codereview.appspot.com/151200043/diff/1/quickstart/models/envs.py
File quickstart/models/envs.py (right):

https://codereview.appspot.com/151200043/diff/1/quickstart/models/envs.py#new...
quickstart/models/envs.py:678: help='The MAAS API key. This can be found by
going to the '
On 2014/10/01 14:52:14, rharding wrote:
> I'd tweak this to make it clear it's the 'user preference' dialog vs the MAAS
> configuration page. We might even supply a link there like
/MAAS/account/prefs/

Done.

Expand All Messages | Collapse All Messages