Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 151200043: Add MAAS support to quickstart.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by frankban
Modified:
10 years, 6 months ago
Reviewers:
mp+236713, bac, rharding
Visibility:
Public.

Description

Add MAAS support to quickstart. Also bump version up and update tge default Juju GUI charm URLs used when charmworld cannot be contacted. Tests: `make check`. QA: already done on a live MAAS instance. However, it is possible to just try to create a MAAS environment YAML via the interactive session. https://code.launchpad.net/~frankban/juju-quickstart/maas/+merge/236713 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add MAAS support to quickstart. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M quickstart/models/envs.py View 1 chunk +37 lines, -0 lines 0 comments Download
M quickstart/settings.py View 1 chunk +2 lines, -2 lines 0 comments Download
M quickstart/tests/models/test_envs.py View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 6 months ago (2014-10-01 13:48:05 UTC) #1
bac
On 2014/10/01 13:48:05, frankban wrote: > Please take a look. LGTM. I did the minimal ...
10 years, 6 months ago (2014-10-01 14:07:10 UTC) #2
rharding
LGTM with one bit of feedback on the wording. Thanks! https://codereview.appspot.com/151200043/diff/1/quickstart/models/envs.py File quickstart/models/envs.py (right): https://codereview.appspot.com/151200043/diff/1/quickstart/models/envs.py#newcode678 ...
10 years, 6 months ago (2014-10-01 14:52:15 UTC) #3
frankban
*** Submitted: Add MAAS support to quickstart. Also bump version up and update tge default ...
10 years, 6 months ago (2014-10-01 15:32:02 UTC) #4
frankban
10 years, 6 months ago (2014-10-01 15:32:44 UTC) #5
Thanks for the reviews!

https://codereview.appspot.com/151200043/diff/1/quickstart/models/envs.py
File quickstart/models/envs.py (right):

https://codereview.appspot.com/151200043/diff/1/quickstart/models/envs.py#new...
quickstart/models/envs.py:678: help='The MAAS API key. This can be found by
going to the '
On 2014/10/01 14:52:14, rharding wrote:
> I'd tweak this to make it clear it's the 'user preference' dialog vs the MAAS
> configuration page. We might even supply a link there like
/MAAS/account/prefs/

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b