Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 151041: include line number in each change header in mail

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by rsc_swtch
Modified:
16 years, 7 months ago
Reviewers:
GvR
Base URL:
http://rietveld.googlecode.com/svn/trunk/codereview/
Visibility:
Public.

Description

When reading the mail from a very long review, it is difficult, looking at a single comment that says Line 123, to scan backward in the mail to find the immediately preceding File line. All the stanzas look about the same. This patch changes the introductory text from Line 123: to filename:123: as is commonly used for compiler error messages and the like. This avoids the problem of having to scan backward to figure out which file is being discussed. The problem is particularly acute when you get a batch of replies that is maybe 25 "Done." across a few different files and you see the one substantial reply and can't immediately match it to a file.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M views.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
rsc_swtch
16 years, 7 months ago (2009-11-05 22:59:08 UTC) #1
GvR
16 years, 7 months ago (2009-11-05 23:09:23 UTC) #2
LG.

Submitted as r483 and made live on codereview.appspot.com.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b