Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(382)

Issue 15100046: Add recent bzr changes to bundles.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by benji
Modified:
7 years, 6 months ago
Reviewers:
bac, mp+192389
Visibility:
Public.

Description

Add recent bzr changes to bundles. https://code.launchpad.net/~benji/charmworld/expose-bundle-changes/+merge/192389 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add recent bzr changes to bundles. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -69 lines) Patch
[revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
charmworld/jobs/ingest.py View 7 chunks +33 lines, -23 lines 0 comments Download
charmworld/jobs/tests/test_bzr.py View 3 chunks +51 lines, -22 lines 0 comments Download
charmworld/jobs/tests/test_ingest.py View 2 chunks +3 lines, -3 lines 0 comments Download
charmworld/migrations/versions/tests/test_migrations.py View 1 chunk +1 line, -0 lines 0 comments Download
charmworld/models.py View 3 chunks +10 lines, -5 lines 0 comments Download
charmworld/templates/bundle.pt View 1 chunk +0 lines, -8 lines 0 comments Download
charmworld/testing/factory.py View 1 chunk +2 lines, -1 line 0 comments Download
charmworld/tests/test_models.py View 6 chunks +15 lines, -4 lines 0 comments Download
charmworld/tests/test_search.py View 1 chunk +3 lines, -2 lines 0 comments Download
charmworld/views/tests/test_api.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
benji
Please take a look.
7 years, 6 months ago (2013-10-23 18:33:44 UTC) #1
bac
LGTM https://codereview.appspot.com/15100046/diff/1/charmworld/jobs/ingest.py File charmworld/jobs/ingest.py (right): https://codereview.appspot.com/15100046/diff/1/charmworld/jobs/ingest.py#newcode424 charmworld/jobs/ingest.py:424: if revision.timestamp < since: So since cannot be ...
7 years, 6 months ago (2013-10-23 18:41:54 UTC) #2
benji
Thanks for the review. https://codereview.appspot.com/15100046/diff/1/charmworld/jobs/ingest.py File charmworld/jobs/ingest.py (right): https://codereview.appspot.com/15100046/diff/1/charmworld/jobs/ingest.py#newcode424 charmworld/jobs/ingest.py:424: if revision.timestamp < since: On ...
7 years, 6 months ago (2013-10-23 18:46:49 UTC) #3
benji
7 years, 6 months ago (2013-10-23 18:52:45 UTC) #4
*** Submitted:

Add recent bzr changes to bundles.

R=bac
CC=
https://codereview.appspot.com/15100046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b