code review 15100044: fossil: fix remaining warnings

fossil: fix remaining warnings

[0intro, 2013-10-22 20:40:34]

Hello rsc,

I'd like you to review this change to
https://code.google.com/p/plan9port

[rsc, 2013-10-23 14:13:51]

LGTM

instead of making the pointers const, can you just add a cast in the
conversion?

mc0 = (MetaChunk*)s0;

for example.

[0intro, 2013-10-23 18:16:26]

Hello rsc, rsc@golang.org,

Please take another look.

[rsc, 2013-10-23 18:20:53]

LGTM

https://codereview.appspot.com/15100044/diff/150001/src/cmd/fossil/flfmt9660.c
File src/cmd/fossil/flfmt9660.c (right):

https://codereview.appspot.com/15100044/diff/150001/src/cmd/fossil/flfmt9660....
src/cmd/fossil/flfmt9660.c:237: if(memcmp(v->magic,
"\x01\x43\x44\x30\x30\x31\x01\x00", 8) != 0)
how about "\001CD001\001\000"?

[0intro, 2013-10-23 18:30:44]

Hello rsc, rsc@golang.org,

Please take another look.

[0intro, 2013-10-23 18:33:30]

https://codereview.appspot.com/15100044/diff/150001/src/cmd/fossil/flfmt9660.c
File src/cmd/fossil/flfmt9660.c (right):

https://codereview.appspot.com/15100044/diff/150001/src/cmd/fossil/flfmt9660....
src/cmd/fossil/flfmt9660.c:237: if(memcmp(v->magic,
"\x01\x43\x44\x30\x30\x31\x01\x00", 8) != 0)
On 2013/10/23 18:20:53, rsc wrote:
> how about "\001CD001\001\000"?

Done.

[rsc, 2013-10-23 18:55:42]

LGTM

For what it's worth, if I say LGTM but make a few comments and you address
those comments, feel free to submit without another round.

[0intro, 2013-10-23 20:09:51]

OK, thanks!

[0intro, 2013-10-23 20:10:41]

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=d75b433706b7 ***

fossil: fix remaining warnings

R=rsc
https://codereview.appspot.com/15100044