|
|
DescriptionIssue 4128
Add an alternative Drum Style - agostini-drums-style
An alternative to the existing drum-style
provided in lilypond.
This allows the typesetting of a typical drum kit
on a five-line staff. Created by Dante Agostini a
French drummer and teacher known for his drum
school (in 1965).
Patch Set 1 #
Total comments: 2
Patch Set 2 : With corrections by Phil H and David K #
Total comments: 1
Patch Set 3 : After Phil and David's comments #
MessagesTotal messages: 18
Please review - note I am merely shepherding this patch for Frederic Gohier.
Sign in to reply to this message.
https://codereview.appspot.com/150860044/diff/1/Documentation/notation/percus... File Documentation/notation/percussion.itely (right): https://codereview.appspot.com/150860044/diff/1/Documentation/notation/percus... Documentation/notation/percussion.itely:271: It typesets a typical drum kit on a five-line staff created by I'd organize this a bit differently. The sentence at the bottom sounds too defensive, and I'd leave out most of the details here. Instead of explaining who Agostini was, it would be more important to composers/typesetters to know when they can expect to counter this notation and when they might be expected to produce it. I'd write something like the following (I am _completely_ making this up, so please change all the factual statements): This alternative drum style is named after the French drummer Dante Agostini who invented it in 1965. It uses a different layout of instruments in a five-line staff. Initially employed for psychodelic rock, it is still the prevalent notation style for North Italian Cabeza music. Probably the most notable difference
Sign in to reply to this message.
----- Original Message ----- From: <dak@gnu.org> To: <pkx166h@gmail.com>; <fgohier49@hotmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Tuesday, September 23, 2014 2:23 PM Subject: Re: Add an alternative Drum Style - agostini-drums-style (issue150860044 by pkx166h@gmail.com) > > https://codereview.appspot.com/150860044/diff/1/Documentation/notation/percus... > File Documentation/notation/percussion.itely (right): > > https://codereview.appspot.com/150860044/diff/1/Documentation/notation/percus... > Documentation/notation/percussion.itely:271: It typesets a typical drum > kit on a five-line staff created by > I'd organize this a bit differently. The sentence at the bottom sounds > too defensive, and I'd leave out most of the details here. Instead of > explaining who Agostini was, it would be more important to > composers/typesetters to know when they can expect to counter this > notation and when they might be expected to produce it. > > I'd write something like the following (I am _completely_ making this > up, so please change all the factual statements): > > This alternative drum style is named after the French drummer Dante > Agostini who invented it in 1965. It uses a different layout of > instruments in a five-line staff. Initially employed for psychodelic > rock, it is still the prevalent notation style for North Italian Cabeza > music. > > Probably the most notable difference psychedelic, FWIW. -- Phil Holmes
Sign in to reply to this message.
With corrections by Phil H and David K
Sign in to reply to this message.
Hello, please find attached , the new version thanks for you help to create the new patch set Cordialement, GOHIER Frédéric https://codereview.appspot.com/150860044/diff/1/Documentation/notation/percus... File Documentation/notation/percussion.itely (right): https://codereview.appspot.com/150860044/diff/1/Documentation/notation/percus... Documentation/notation/percussion.itely:271: It typesets a typical drum kit on a five-line staff created by On 2014/09/23 13:23:31, dak wrote: > I'd organize this a bit differently. The sentence at the bottom sounds too > defensive, and I'd leave out most of the details here. Instead of explaining > who Agostini was, it would be more important to composers/typesetters to know > when they can expect to counter this notation and when they might be expected to > produce it. > > I'd write something like the following (I am _completely_ making this up, so > please change all the factual statements): > > This alternative drum style is named after the French drummer Dante Agostini > who invented it in 1965. It uses a different layout of instruments in a > five-line staff. Initially employed for psychodelic rock, it is still the > prevalent notation style for North Italian Cabeza music. > > Probably the most notable difference Done.
Sign in to reply to this message.
https://codereview.appspot.com/150860044/diff/20001/Documentation/notation/pe... File Documentation/notation/percussion.itely (right): https://codereview.appspot.com/150860044/diff/20001/Documentation/notation/pe... Documentation/notation/percussion.itely:274: prevalent notation style for North Italian Cabeza music. Cough, cough. That sounds entirely made up. Which is no surprise since it _was_ entirely made up by me in order to sketch the _kind_ of information we want to provide. And I definitely pointed out that the facts in my example text were made up and should be replaced by proper facts. Any chance we can get this information from the original patch author, or does someone else need to do the respective research?
Sign in to reply to this message.
On 2014/09/24 12:11:12, dak wrote: > https://codereview.appspot.com/150860044/diff/20001/Documentation/notation/pe... > File Documentation/notation/percussion.itely (right): > > https://codereview.appspot.com/150860044/diff/20001/Documentation/notation/pe... > Documentation/notation/percussion.itely:274: prevalent notation style for North > Italian Cabeza music. > Cough, cough. That sounds entirely made up. Which is no surprise since it > _was_ entirely made up by me in order to sketch the _kind_ of information we > want to provide. And I definitely pointed out that the facts in my example text > were made up and should be replaced by proper facts. > > Any chance we can get this information from the original patch author, or does > someone else need to do the respective research? Hello, I am not aware about the life of Dante Agostini, I was thinking with this comment your were more than me. Can we extract some informations from any website to use here ? I am not confident with this.
Sign in to reply to this message.
On 2014/09/24 13:56:36, fgohier49 wrote: > On 2014/09/24 12:11:12, dak wrote: > > > > Any chance we can get this information from the original patch author, or does > > someone else need to do the respective research? > > > Hello, > > I am not aware about the life of Dante Agostini, I was thinking with this > comment your were more than me. > Can we extract some informations from any website to use here ? I am not > confident with this. The life of Agostini is not really important. What would be important would be for LilyPond users to know when and why to use this notation. There has to be some reason you want to see it added to LilyPond: this notation has to be used _somewhere_. So the question is _where_ this notation is being used.
Sign in to reply to this message.
On 2014/09/24 14:08:39, dak wrote: > On 2014/09/24 13:56:36, fgohier49 wrote: > > On 2014/09/24 12:11:12, dak wrote: > > > > > > > Any chance we can get this information from the original patch author, or > does > > > someone else need to do the respective research? > > > > > > Hello, > > > > I am not aware about the life of Dante Agostini, I was thinking with this > > comment your were more than me. > > Can we extract some informations from any website to use here ? I am not > > confident with this. > > The life of Agostini is not really important. What would be important would be > for LilyPond users to know when and why to use this notation. There has to be > some reason you want to see it added to LilyPond: this notation has to be used > _somewhere_. So the question is _where_ this notation is being used. Hello, this notation is used by almost all french drummers. His school is know developped in all french big towns, in more, Dusseldorf (Germany), Bâle (Schweiz), Athens (Greece), Pordenonde & Udine (Italy), Rabat (Maroc), without take in count all other teachers which are not linked directly to the school. His method is written in french, english, spanish & german. It seems the most used notation in europe
Sign in to reply to this message.
2014-09-24 19:53 GMT+02:00 <fgohier49@hotmail.com>: > Pordenonde Just in case this is actually going in the documentation, the name of that Italian city is Pordenone and not Pordenonde. Best wishes. Davide
Sign in to reply to this message.
On 2014/09/24 17:53:33, fgohier49 wrote: > On 2014/09/24 14:08:39, dak wrote: > > On 2014/09/24 13:56:36, fgohier49 wrote: > > > On 2014/09/24 12:11:12, dak wrote: > > > > > > > > > > Any chance we can get this information from the original patch author, or > > does > > > > someone else need to do the respective research? > > > > > > > > > Hello, > > > > > > I am not aware about the life of Dante Agostini, I was thinking with this > > > comment your were more than me. > > > Can we extract some informations from any website to use here ? I am not > > > confident with this. > > > > The life of Agostini is not really important. What would be important would > be > > for LilyPond users to know when and why to use this notation. There has to be > > some reason you want to see it added to LilyPond: this notation has to be used > > _somewhere_. So the question is _where_ this notation is being used. > > Hello, > > this notation is used by almost all french drummers. His school is know > developped in all french big towns, in more, Dusseldorf (Germany), Bâle > (Schweiz), Athens (Greece), Pordenonde & Udine (Italy), Rabat (Maroc), without > take in count all other teachers which are not linked directly to the school. > His method is written in french, english, spanish & german. > It seems the most used notation in europe Well, that sounds slightly relevant indeed. How about: Invented by the French percussionist Dante Agostini in 1965, this notation is commonly employed in France but also elsewhere. I think that's enough history and gives a sketch about where it can be expected to be used.
Sign in to reply to this message.
On 2014/09/24 18:19:43, dak wrote: > On 2014/09/24 17:53:33, fgohier49 wrote: > > On 2014/09/24 14:08:39, dak wrote: > > > On 2014/09/24 13:56:36, fgohier49 wrote: > > > > On 2014/09/24 12:11:12, dak wrote: > > > > > > > > > > > > > Any chance we can get this information from the original patch author, > or > > > does > > > > > someone else need to do the respective research? > > > > > > > > > > > > Hello, > > > > > > > > I am not aware about the life of Dante Agostini, I was thinking with this > > > > comment your were more than me. > > > > Can we extract some informations from any website to use here ? I am not > > > > confident with this. > > > > > > The life of Agostini is not really important. What would be important would > > be > > > for LilyPond users to know when and why to use this notation. There has to > be > > > some reason you want to see it added to LilyPond: this notation has to be > used > > > _somewhere_. So the question is _where_ this notation is being used. > > > > Hello, > > > > this notation is used by almost all french drummers. His school is know > > developped in all french big towns, in more, Dusseldorf (Germany), Bâle > > (Schweiz), Athens (Greece), Pordenonde & Udine (Italy), Rabat (Maroc), without > > take in count all other teachers which are not linked directly to the school. > > His method is written in french, english, spanish & german. > > It seems the most used notation in europe > > Well, that sounds slightly relevant indeed. How about: > > Invented by the French percussionist Dante Agostini in 1965, this notation is > commonly employed in France but also elsewhere. > > I think that's enough history and gives a sketch about where it can be expected > to be used. OK, I will update it next monday
Sign in to reply to this message.
After Phil and David's comments
Sign in to reply to this message.
New patch uploaded.
Sign in to reply to this message.
Patch counted down - Frederic, can you give me a new git formatted patch (just to make sure it is rebased against current master), and I'll push it for you. James
Sign in to reply to this message.
author frederic gohier <fgohier49@hotmail.com> Mon, 29 Sep 2014 20:09:00 +0000 (22:09 +0200) committer James Lowe <pkx166h@gmail.com> Mon, 6 Oct 2014 19:14:34 +0000 (20:14 +0100) commit 6eaaa4d7043bd154d273ced1417dfff9f6c24c10
Sign in to reply to this message.
author frederic gohier <fgohier49@hotmail.com> Mon, 29 Sep 2014 20:09:00 +0000 (22:09 +0200) committer James Lowe <pkx166h@gmail.com> Mon, 6 Oct 2014 19:14:34 +0000 (20:14 +0100) commit [r6eaaa4d7043bd154d273ced1417dfff9f6c24c10] Labels: -Patch-push Fixed_2_19_16 Status: Fixed
Sign in to reply to this message.
|