Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(501)

Issue 150860044: Add an alternative Drum Style - agostini-drums-style (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by pkx166h
Modified:
7 years, 1 month ago
Reviewers:
fgohier49
Visibility:
Public.

Description

Issue 4128 Add an alternative Drum Style - agostini-drums-style An alternative to the existing drum-style provided in lilypond. This allows the typesetting of a typical drum kit on a five-line staff. Created by Dante Agostini a French drummer and teacher known for his drum school (in 1965).

Patch Set 1 #

Total comments: 2

Patch Set 2 : With corrections by Phil H and David K #

Total comments: 1

Patch Set 3 : After Phil and David's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -2 lines) Patch
M Documentation/fr/notation/percussion.itely View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M Documentation/notation/percussion.itely View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M ly/drumpitch-init.ly View 1 chunk +34 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18
pkx166h
Please review - note I am merely shepherding this patch for Frederic Gohier.
9 years, 7 months ago (2014-09-23 12:30:59 UTC) #1
dak
https://codereview.appspot.com/150860044/diff/1/Documentation/notation/percussion.itely File Documentation/notation/percussion.itely (right): https://codereview.appspot.com/150860044/diff/1/Documentation/notation/percussion.itely#newcode271 Documentation/notation/percussion.itely:271: It typesets a typical drum kit on a five-line ...
9 years, 7 months ago (2014-09-23 13:23:31 UTC) #2
mail_philholmes.net
----- Original Message ----- From: <dak@gnu.org> To: <pkx166h@gmail.com>; <fgohier49@hotmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Tuesday, September ...
9 years, 7 months ago (2014-09-23 13:53:11 UTC) #3
pkx166h
9 years, 7 months ago (2014-09-23 16:29:26 UTC) #4
pkx166h
With corrections by Phil H and David K
9 years, 7 months ago (2014-09-24 11:15:43 UTC) #5
pkx166h
Hello, please find attached , the new version thanks for you help to create the ...
9 years, 7 months ago (2014-09-24 11:16:42 UTC) #6
dak
https://codereview.appspot.com/150860044/diff/20001/Documentation/notation/percussion.itely File Documentation/notation/percussion.itely (right): https://codereview.appspot.com/150860044/diff/20001/Documentation/notation/percussion.itely#newcode274 Documentation/notation/percussion.itely:274: prevalent notation style for North Italian Cabeza music. Cough, ...
9 years, 7 months ago (2014-09-24 12:11:12 UTC) #7
fgohier49
On 2014/09/24 12:11:12, dak wrote: > https://codereview.appspot.com/150860044/diff/20001/Documentation/notation/percussion.itely > File Documentation/notation/percussion.itely (right): > > https://codereview.appspot.com/150860044/diff/20001/Documentation/notation/percussion.itely#newcode274 > ...
9 years, 7 months ago (2014-09-24 13:56:36 UTC) #8
dak
On 2014/09/24 13:56:36, fgohier49 wrote: > On 2014/09/24 12:11:12, dak wrote: > > > > ...
9 years, 7 months ago (2014-09-24 14:08:39 UTC) #9
fgohier49
On 2014/09/24 14:08:39, dak wrote: > On 2014/09/24 13:56:36, fgohier49 wrote: > > On 2014/09/24 ...
9 years, 7 months ago (2014-09-24 17:53:33 UTC) #10
davide.liessi
2014-09-24 19:53 GMT+02:00 <fgohier49@hotmail.com>: > Pordenonde Just in case this is actually going in the ...
9 years, 7 months ago (2014-09-24 18:09:08 UTC) #11
dak
On 2014/09/24 17:53:33, fgohier49 wrote: > On 2014/09/24 14:08:39, dak wrote: > > On 2014/09/24 ...
9 years, 7 months ago (2014-09-24 18:19:43 UTC) #12
fgohier49
On 2014/09/24 18:19:43, dak wrote: > On 2014/09/24 17:53:33, fgohier49 wrote: > > On 2014/09/24 ...
9 years, 7 months ago (2014-09-25 16:18:52 UTC) #13
pkx166h
After Phil and David's comments
9 years, 7 months ago (2014-09-30 20:26:24 UTC) #14
pkx166h
New patch uploaded.
9 years, 7 months ago (2014-09-30 20:27:07 UTC) #15
pkx166h
Patch counted down - Frederic, can you give me a new git formatted patch (just ...
9 years, 6 months ago (2014-10-06 07:18:46 UTC) #16
pkx166h
author frederic gohier <fgohier49@hotmail.com> Mon, 29 Sep 2014 20:09:00 +0000 (22:09 +0200) committer James Lowe ...
9 years, 6 months ago (2014-10-06 19:17:15 UTC) #17
pkx166h
7 years, 1 month ago (2017-03-19 12:04:23 UTC) #18
author    frederic gohier <fgohier49@hotmail.com>   
    Mon, 29 Sep 2014 20:09:00 +0000 (22:09 +0200)
committer    James Lowe <pkx166h@gmail.com>   
    Mon, 6 Oct 2014 19:14:34 +0000 (20:14 +0100)
commit    [r6eaaa4d7043bd154d273ced1417dfff9f6c24c10]

Labels: -Patch-push Fixed_2_19_16
Status: Fixed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b