Issue 15070044: Viewing bundle topology no longer breaks main topo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 15070044: Viewing bundle topology no longer breaks main topo

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by jeff.pihach

Modified:
10 years, 7 months ago

Reviewers:
mp+191886, gary.poster

Visibility:
Public.

Description

Viewing bundle topology no longer breaks main topo The events object was passing the nested objects by reference causing event binding issues on the primary topology. https://code.launchpad.net/~hatch/juju-gui/bundle-deploy-panzoom-fix/+merge/191886 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Viewing bundle topology no longer breaks main topo #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -3 lines)			Patch
[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
app/assets/javascripts/d3-components.js	View		1 chunk	+1 line, -1 line	0 comments	Download
test/test_d3_components.js	View	1	3 chunks	+22 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

LGTM with simple test. Good catch and thank you! Gary

10 years, 7 months ago (2013-10-18 21:02:42 UTC) #2

jeff.pihach

10 years, 7 months ago (2013-10-18 22:15:49 UTC) #4

*** Submitted:

Viewing bundle topology no longer breaks main topo

The events object was passing the nested objects by reference causing
event binding issues on the primary topology.

R=gary.poster
CC=
https://codereview.appspot.com/15070044

Expand All Messages | Collapse All Messages