Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2310)

Issue 15060051: cloudinit: Use cloud archive key not short key id

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by gz
Modified:
10 years, 6 months ago
Reviewers:
mp+192414, axw, ssmoser
Visibility:
Public.

Description

cloudinit: Use cloud archive key not short key id Currently, when adding the cloud archive to apt_sources for precise, we supply the short key id to obtain the signing key. However, this requires access to the keyserver, which not all deployments will have. By supplying the full text of the public key instead, we can verify the download without needing additional access. The is a package in precise containing this key, alas we can't just add that as the apt_sources step runs first, and update with the cloud archive will fail unless the key is approved before installing packages. https://code.launchpad.net/~gz/juju-core/cloud_archive_key/+merge/192414 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cloudinit: Use cloud archive key not short key id #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -40 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cloudinit/cloudinit.go View 1 1 chunk +3 lines, -5 lines 0 comments Download
M cloudinit/cloudinit_test.go View 1 chunk +0 lines, -7 lines 0 comments Download
M cloudinit/options.go View 1 chunk +0 lines, -13 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 2 chunks +50 lines, -3 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 1 3 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 4
gz
Please take a look.
10 years, 6 months ago (2013-10-23 22:30:06 UTC) #1
axw
On 2013/10/23 22:30:06, gz wrote: > Please take a look. LGTM, perhaps with a test ...
10 years, 6 months ago (2013-10-23 22:38:54 UTC) #2
gz
Please take a look.
10 years, 6 months ago (2013-10-23 23:56:14 UTC) #3
ssmoser
10 years, 6 months ago (2013-10-24 00:37:17 UTC) #4
On 2013/10/23 23:56:14, gz wrote:
> Please take a look.

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b