Support access to google base attribute child's of attribute with type like "group"

[jcgregorio, 2010-06-07 18:55:16]

This is looking good, formatting and test coverage comments below.

http://codereview.appspot.com/1505041/diff/1/3
File src/gdata/base/__init__.py (right):

http://codereview.appspot.com/1505041/diff/1/3#newcode159
src/gdata/base/__init__.py:159: if sub.attrib.has_key('type'): sub_type =
sub.attrib['type']
Please conform to the surrounding coding style, in this case:

if cond:
  pass
else:
  pass

http://codereview.appspot.com/1505041/diff/1/2
File tests/gdata_tests/base/data_test.py (right):

http://codereview.appspot.com/1505041/diff/1/2#newcode71
tests/gdata_tests/base/data_test.py:71:
self.assert_(len(attr.item_attributes)==1)
Should you also have a test that serializes the constructed model back into XML
and be sure that the added item attributes are there?

http://codereview.appspot.com/1505041/diff/1/2#newcode82
tests/gdata_tests/base/data_test.py:82: 
Minor: one blank line between functions, 2 blank lines between class
definitions.

[seriy.pr, 2010-06-28 09:18:24]

Updated.
On 2010/06/07 18:55:16, jcgregorio wrote:
> This is looking good, formatting and test coverage comments below.
> 
> http://codereview.appspot.com/1505041/diff/1/3
> File src/gdata/base/__init__.py (right):
> 
> http://codereview.appspot.com/1505041/diff/1/3#newcode159
> src/gdata/base/__init__.py:159: if sub.attrib.has_key('type'): sub_type =
> sub.attrib['type']
> Please conform to the surrounding coding style, in this case:
> 
> if cond:
>   pass
> else:
>   pass
> 
> http://codereview.appspot.com/1505041/diff/1/2
> File tests/gdata_tests/base/data_test.py (right):
> 
> http://codereview.appspot.com/1505041/diff/1/2#newcode71
> tests/gdata_tests/base/data_test.py:71:
> self.assert_(len(attr.item_attributes)==1)
> Should you also have a test that serializes the constructed model back into
XML
> and be sure that the added item attributes are there?
> 
> http://codereview.appspot.com/1505041/diff/1/2#newcode82
> tests/gdata_tests/base/data_test.py:82: 
> Minor: one blank line between functions, 2 blank lines between class
> definitions.

[jcgregorio, 2010-06-28 17:37:38]

LGTM. Committed on revision 990. Thanks! -joe