Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113)

Issue 150370043: code review 150370043: cmd/ld: don't add line number info for the final addres... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by iant
Modified:
7 years, 1 month ago
Reviewers:
r
CC:
golang-codereviews, r
Visibility:
Public.

Description

cmd/ld: don't add line number info for the final address of an FDE This makes dwardump --verify happy. Update issue 8846

Patch Set 1 #

Patch Set 2 : diff -r 61525d46311930992512297749c1ad914912041b https://code.google.com/p/go #

Patch Set 3 : diff -r d56326309b20f195edd23baac9271548cd999328 https://code.google.com/p/go #

Patch Set 4 : diff -r 411fad125b02340577f25b25dae7a985ecede614 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/cmd/ld/dwarf.c View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 3
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
7 years, 2 months ago (2014-10-03 00:41:17 UTC) #1
r
LGTM
7 years, 1 month ago (2014-10-08 21:37:52 UTC) #2
iant
7 years, 1 month ago (2014-10-08 23:17:37 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=f3ab37e2d965 ***

cmd/ld: don't add line number info for the final address of an FDE

This makes dwardump --verify happy.

Update issue 8846

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/150370043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b