Issue 150370043: code review 150370043: cmd/ld: don't add line number info for the final addres...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 150370043: code review 150370043: cmd/ld: don't add line number info for the final addres... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by iant

Modified:
9 years, 6 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

cmd/ld: don't add line number info for the final address of an FDE This makes dwardump --verify happy. Update issue 8846

Patch Set 1 #

Patch Set 2 : diff -r 61525d46311930992512297749c1ad914912041b https://code.google.com/p/go #

Patch Set 3 : diff -r d56326309b20f195edd23baac9271548cd999328 https://code.google.com/p/go #

Patch Set 4 : diff -r 411fad125b02340577f25b25dae7a985ecede614 https://code.google.com/p/go #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	src/cmd/ld/dwarf.c	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 6 months ago (2014-10-03 00:41:17 UTC) #1

iant

9 years, 6 months ago (2014-10-08 23:17:37 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f3ab37e2d965 ***

cmd/ld: don't add line number info for the final address of an FDE

This makes dwardump --verify happy.

Update issue 8846

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/150370043

Expand All Messages | Collapse All Messages