Fix bugs in PyFullFeedback

Committed as r893.

[Collin Winter, 2009-11-05 21:49:34]

PTAL

[Jeffrey Yasskin, 2009-11-05 21:54:31]

http://codereview.appspot.com/150041/diff/1/2
File Util/RuntimeFeedback.cc (right):

http://codereview.appspot.com/150041/diff/1/2#newcode274
Line 274: for (TypeSet::iterator it = rhs.data_.begin(), end = rhs.data_.end();
It's a problem here too, and in the copy constructor, right?

http://codereview.appspot.com/150041/diff/1/2#newcode289
Line 289: if (this->usage_ == TypeMode) {
Is there a test that should catch this?

http://codereview.appspot.com/150041/diff/1/2#newcode346
Line 346: for (TypeSet::const_iterator it = this->data_.begin(),
If this is being used for functions too, "TypeSet" doesn't seem like the right
name for its type.

[Collin Winter, 2009-11-10 21:19:50]

PTAL

http://codereview.appspot.com/150041/diff/1/2
File Util/RuntimeFeedback.cc (right):

http://codereview.appspot.com/150041/diff/1/2#newcode274
Util/RuntimeFeedback.cc:274: for (TypeSet::iterator it = rhs.data_.begin(), end
= rhs.data_.end();
On 2009/11/05 21:54:31, Jeffrey Yasskin wrote:
> It's a problem here too, and in the copy constructor, right?

Done.

http://codereview.appspot.com/150041/diff/1/2#newcode289
Util/RuntimeFeedback.cc:289: if (this->usage_ == TypeMode) {
On 2009/11/05 21:54:31, Jeffrey Yasskin wrote:
> Is there a test that should catch this?

I've tried to come up with a reliable test case on all platforms, but it's
proving to be more work than it's worth. I've added other tests, and verified
that the test that was failing on Linux now passes.

http://codereview.appspot.com/150041/diff/1/2#newcode346
Util/RuntimeFeedback.cc:346: for (TypeSet::const_iterator it =
this->data_.begin(),
On 2009/11/05 21:54:31, Jeffrey Yasskin wrote:
> If this is being used for functions too, "TypeSet" doesn't seem like the right
> name for its type.

Done.

[Jeffrey Yasskin, 2009-11-10 21:26:29]

LGTM

http://codereview.appspot.com/150041/diff/2007/3005
File Util/RuntimeFeedback.cc (right):

http://codereview.appspot.com/150041/diff/2007/3005#newcode257
Util/RuntimeFeedback.cc:257: this->data_.clear();
No need to clear this->data_. It was just created, so it's definitely empty.

[Collin Winter, 2009-11-10 21:42:29]

Committing.

http://codereview.appspot.com/150041/diff/2007/3005
File Util/RuntimeFeedback.cc (right):

http://codereview.appspot.com/150041/diff/2007/3005#newcode257
Util/RuntimeFeedback.cc:257: this->data_.clear();
On 2009/11/10 21:26:29, Jeffrey Yasskin wrote:
> No need to clear this->data_. It was just created, so it's definitely empty.

Done.